fix(mempool_p2p): fix default config values (#1881)

starkware-libs · Nov 11, 2024 · 11431fa · 11431fa
1 parent 1ed9911
commit 11431fa
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/config/mempool/default_config.json b/config/mempool/default_config.json
@@ -782,7 +782,7 @@
   "mempool_p2p_config.network_buffer_size": {
     "description": "Network buffer size.",
     "privacy": "Public",
-    "value": 0
+    "value": 10000
   },
   "mempool_p2p_config.network_config.advertised_multiaddr": {
     "description": "The external address other peers see this node. If this is set, the node will not try to find out which addresses it has and will write this address as external instead",

diff --git a/crates/mempool_p2p/src/config.rs b/crates/mempool_p2p/src/config.rs
@@ -6,7 +6,7 @@ use papyrus_network::NetworkConfig;
 use serde::{Deserialize, Serialize};
 use validator::Validate;
 
-#[derive(Debug, Default, Deserialize, Serialize, Clone, PartialEq, Validate)]
+#[derive(Debug, Deserialize, Serialize, Clone, PartialEq, Validate)]
 pub struct MempoolP2pConfig {
     #[validate]
     pub network_config: NetworkConfig,
@@ -15,6 +15,17 @@ pub struct MempoolP2pConfig {
     pub network_buffer_size: usize,
 }
 
+impl Default for MempoolP2pConfig {
+    fn default() -> Self {
+        Self {
+            network_config: NetworkConfig::default(),
+            // TODO: Consider filling this once the sequencer node has a name.
+            executable_version: None,
+            network_buffer_size: 10000,
+        }
+    }
+}
+
 impl SerializeConfig for MempoolP2pConfig {
     fn dump(&self) -> BTreeMap<ParamPath, SerializedParam> {
         vec![