Skip to content

Commit

Permalink
feat(blockifier): add get_syscall_gas_cost to versioned constants impl
Browse files Browse the repository at this point in the history
  • Loading branch information
Yonatan-Starkware committed Nov 24, 2024
1 parent 7072ab0 commit 2264509
Show file tree
Hide file tree
Showing 2 changed files with 49 additions and 0 deletions.
27 changes: 27 additions & 0 deletions crates/blockifier/src/versioned_constants.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ use crate::execution::execution_utils::poseidon_hash_many_cost;
use crate::execution::syscalls::SyscallSelector;
use crate::fee::resources::StarknetResources;
use crate::transaction::transaction_types::TransactionType;
use crate::utils::u64_from_usize;

#[cfg(test)]
#[path = "versioned_constants_test.rs"]
Expand Down Expand Up @@ -330,6 +331,32 @@ impl VersionedConstants {
GasVectorComputationMode::NoL2Gas => &self.deprecated_l2_resource_gas_costs,
}
}

/// Calculates the syscall gas cost from the OS resources.
pub fn get_syscall_gas_cost(&self, syscall_selector: &SyscallSelector) -> u64 {
let gas_costs = &self.os_constants.gas_costs;
let execution_resources = &self
.os_resources
.execute_syscalls
.get(syscall_selector)
.expect("Fetching the execution resources of a syscall should not fail.");
// The minimum total cost is `syscall_base_gas_cost`, which is pre-charged by the compiler.
let n_steps = u64_from_usize(execution_resources.n_steps);
let n_memory_holes = u64_from_usize(execution_resources.n_memory_holes);
let mut total_builtin_gas_cost: u64 = 0;
let total_builtin_gas_cost: u64 = execution_resources.builtin_instance_counter.iter().map(|(builtin, amount)| {
let builtin_cost = gas_costs.get_builtin_gas_cost(builtin).unwrap_or_else(|err| panic!("Failed to get gas cost: {}", err));
builtin_cost * u64_from_usize(*amount)
}).sum();


std::cmp::max(
n_steps * gas_costs.step_gas_cost
+ n_memory_holes * gas_costs.memory_hole_gas_cost
+ total_builtin_gas_cost,
gas_costs.syscall_base_gas_cost,
)
}
}

#[derive(Clone, Debug, Default, Deserialize, Eq, PartialEq)]
Expand Down
22 changes: 22 additions & 0 deletions crates/blockifier/src/versioned_constants_test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -167,3 +167,25 @@ fn test_all_jsons_in_enum() {
fn test_latest_no_panic() {
VersionedConstants::latest_constants();
}

#[test]
fn test_correct_syscall_gas_cost_calculation() {
const EXPECTED_CALL_CONTRACT_GAS_COST: u64 = 87650;
const EXPECTED_SECP256K1MUL_GAS_COST: u64 = 8143650;
const EXPECTED_SHA256PROCESSBLOCK_GAS_COST: u64 = 841095;

let versioned_constants = VersionedConstants::latest_constants().clone();

assert_eq!(
versioned_constants.get_syscall_gas_cost(&SyscallSelector::CallContract),
EXPECTED_CALL_CONTRACT_GAS_COST
);
assert_eq!(
versioned_constants.get_syscall_gas_cost(&SyscallSelector::Secp256k1Mul),
EXPECTED_SECP256K1MUL_GAS_COST
);
assert_eq!(
versioned_constants.get_syscall_gas_cost(&SyscallSelector::Sha256ProcessBlock),
EXPECTED_SHA256PROCESSBLOCK_GAS_COST
);
}

0 comments on commit 2264509

Please sign in to comment.