test(starknet_api): set l1 handler tx version to default zero

starkware-libs · Dec 18, 2024 · 39026c3 · 39026c3
1 parent 8fbc491
commit 39026c3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/crates/papyrus_rpc/src/v0_8/execution_test.rs b/crates/papyrus_rpc/src/v0_8/execution_test.rs
@@ -64,6 +64,7 @@ use starknet_api::deprecated_contract_class::ContractClass as SN_API_DeprecatedC
 use starknet_api::hash::StarkHash;
 use starknet_api::state::{StorageKey, ThinStateDiff as StarknetApiStateDiff};
 use starknet_api::test_utils::{path_in_resources, read_json_file};
+use starknet_api::transaction::constants::L1_HANDLER_VERSION;
 use starknet_api::transaction::fields::{Calldata, Fee};
 use starknet_api::transaction::{
     L1HandlerTransaction,
@@ -1204,7 +1205,7 @@ async fn pending_trace_block_transactions_and_trace_transaction_execution_contex
 #[test]
 fn message_from_l1_to_l1_handler_tx() {
     let l1_handler_tx = L1HandlerTransaction::from(MESSAGE_FROM_L1.clone());
-    assert_eq!(l1_handler_tx.version, TransactionVersion::ONE);
+    assert_eq!(l1_handler_tx.version, L1_HANDLER_VERSION);
     assert_eq!(l1_handler_tx.contract_address, *CONTRACT_ADDRESS);
     assert_eq!(l1_handler_tx.entry_point_selector, selector_from_name("l1_handle"));
     // The first item of calldata is the from_address.

diff --git a/crates/papyrus_rpc/src/v0_8/transaction.rs b/crates/papyrus_rpc/src/v0_8/transaction.rs
@@ -27,6 +27,7 @@ use starknet_api::core::{
 use starknet_api::data_availability::DataAvailabilityMode;
 use starknet_api::execution_resources::GasAmount;
 use starknet_api::serde_utils::bytes_from_hex_str;
+use starknet_api::transaction::constants::L1_HANDLER_VERSION;
 use starknet_api::transaction::fields::{
     AccountDeploymentData,
     AllResourceBounds,
@@ -1281,7 +1282,7 @@ impl From<MessageFromL1> for L1HandlerTransaction {
         calldata.extend_from_slice(&message.payload.0);
         let calldata = Calldata(Arc::new(calldata));
         Self {
-            version: TransactionVersion::ONE,
+            version: L1_HANDLER_VERSION,
             contract_address: message.to_address,
             entry_point_selector: message.entry_point_selector,
             calldata,

diff --git a/crates/starknet_api/src/test_utils/l1_handler.rs b/crates/starknet_api/src/test_utils/l1_handler.rs
@@ -1,5 +1,6 @@
 use crate::core::{ContractAddress, EntryPointSelector, Nonce};
 use crate::executable_transaction::L1HandlerTransaction as ExecutableL1HandlerTransaction;
+use crate::transaction::constants::L1_HANDLER_VERSION;
 use crate::transaction::fields::{Calldata, Fee};
 use crate::transaction::{L1HandlerTransaction, TransactionHash, TransactionVersion};
 
@@ -17,7 +18,7 @@ pub struct L1HandlerTxArgs {
 impl Default for L1HandlerTxArgs {
     fn default() -> Self {
         L1HandlerTxArgs {
-            version: TransactionVersion::THREE,
+            version: L1_HANDLER_VERSION,
             nonce: Nonce::default(),
             contract_address: ContractAddress::default(),
             entry_point_selector: EntryPointSelector::default(),