Skip to content

Commit

Permalink
chore(monitoring): clean dependencies, add todos
Browse files Browse the repository at this point in the history
commit-id:3bb41b9a
  • Loading branch information
Itay-Tsabary-Starkware committed Nov 12, 2024
1 parent 4276a78 commit 44bc35e
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions crates/monitoring_endpoint/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,17 @@ workspace = true
[dependencies]
axum.workspace = true
http-body = { workspace = true, optional = true }
hyper = { workspace = true, features = ["full"] }
hyper = { workspace = true }
papyrus_config.workspace = true
serde.workspace = true
starknet_sequencer_infra.workspace = true
tokio = { workspace = true, optional = true }
tower = { workspace = true, optional = true, features = ["util"] }
tower = { workspace = true, optional = true }
tracing.workspace = true
validator.workspace = true

[dev-dependencies]
http-body.workspace = true
pretty_assertions.workspace = true
tokio.workspace = true
tower = { workspace = true, features = ["util"] }
tower.workspace = true
2 changes: 0 additions & 2 deletions crates/monitoring_endpoint/src/monitoring_endpoint_test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ use crate::monitoring_endpoint::{
};
use crate::test_utils::build_request;

// TODO(Tsabary): Clear feature dependencies and dev dependencies.

const TEST_VERSION: &str = "1.2.3-dev";

fn setup_monitoring_endpoint() -> MonitoringEndpoint {
Expand Down
4 changes: 3 additions & 1 deletion crates/monitoring_endpoint/src/test_utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ use tracing::info;

use crate::monitoring_endpoint::{ALIVE, MONITORING_PREFIX};

// TODO(Tsabary): Clean feature dependencies and dev dependencies.
// TODO(Tsabary): try avoid having to use http-body crate from the dependencies.

/// Client for querying 'alive' status of an http server.
pub struct IsAliveClient {
Expand All @@ -33,6 +33,8 @@ impl IsAliveClient {
.map_or(false, |response| response.status().is_success())
}

// TODO(Tsabary/Lev): add sleep time as a parameter, and max retries. Consider using
// 'starknet_client::RetryConfig'.
/// Blocks until 'alive'.
pub async fn await_alive(&self) {
let mut counter = 0;
Expand Down

0 comments on commit 44bc35e

Please sign in to comment.