Skip to content

Commit

Permalink
chore(mempool_p2p): remove unused field from config (#2103)
Browse files Browse the repository at this point in the history
  • Loading branch information
ShahakShama authored Nov 18, 2024
1 parent 6d505c5 commit 4a22a6d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
9 changes: 1 addition & 8 deletions crates/starknet_mempool_p2p/src/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,12 @@ use validator::Validate;
pub struct MempoolP2pConfig {
#[validate]
pub network_config: NetworkConfig,
// TODO: Enter this inside NetworkConfig
pub executable_version: Option<String>,
pub network_buffer_size: usize,
}

impl Default for MempoolP2pConfig {
fn default() -> Self {
Self {
network_config: NetworkConfig::default(),
// TODO: Consider filling this once the sequencer node has a name.
executable_version: None,
network_buffer_size: 10000,
}
Self { network_config: NetworkConfig::default(), network_buffer_size: 10000 }
}
}

Expand Down
3 changes: 2 additions & 1 deletion crates/starknet_mempool_p2p/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ pub fn create_p2p_propagator_and_runner(
) -> (MempoolP2pPropagator, MempoolP2pRunner) {
let mut network_manager = NetworkManager::new(
mempool_p2p_config.network_config,
mempool_p2p_config.executable_version,
// TODO: Consider filling this once the sequencer node has a name.
None,
);
let BroadcastTopicChannels { broadcasted_messages_receiver, broadcast_topic_client } =
network_manager
Expand Down

0 comments on commit 4a22a6d

Please sign in to comment.