refactor(execution): change get fee token blance in state api to get …

…&self and not &mut self (#134)
starkware-libs · Jul 29, 2024 · 5511419 · 5511419
1 parent 66e7f0c
commit 5511419
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 21 deletions.
diff --git a/crates/blockifier/src/state/state_api.rs b/crates/blockifier/src/state/state_api.rs
@@ -52,7 +52,7 @@ pub trait StateReader {
     // TODO(Dori, 1/9/2023): NEW_TOKEN_SUPPORT Determine fee token address based on tx version,
     //   once v3 is introduced.
     fn get_fee_token_balance(
-        &mut self,
+        &self,
         contract_address: ContractAddress,
         fee_token_address: ContractAddress,
     ) -> Result<(Felt, Felt), StateError> {

diff --git a/crates/blockifier/src/transaction/execution_flavors_test.rs b/crates/blockifier/src/transaction/execution_flavors_test.rs
@@ -83,7 +83,7 @@ fn create_flavors_test_state(
 /// Returns the new balance.
 fn check_balance<S: StateReader>(
     current_balance: Felt,
-    state: &mut CachedState<S>,
+    state: &CachedState<S>,
     account_address: ContractAddress,
     chain_info: &ChainInfo,
     fee_type: &FeeType,
@@ -469,7 +469,7 @@ fn test_simulate_validate_charge_fee_mid_execution(
     );
     let current_balance = check_balance(
         current_balance,
-        &mut state,
+        &state,
         account_address,
         &block_context.chain_info,
         &fee_type,
@@ -518,14 +518,8 @@ fn test_simulate_validate_charge_fee_mid_execution(
         // charged final fee is shown in actual_fee.
         if charge_fee { limited_fee } else { unlimited_fee },
     );
-    let current_balance = check_balance(
-        current_balance,
-        &mut state,
-        account_address,
-        chain_info,
-        &fee_type,
-        charge_fee,
-    );
+    let current_balance =
+        check_balance(current_balance, &state, account_address, chain_info, &fee_type, charge_fee);
 
     // Third scenario: only limit is block bounds. Expect resources consumed to be identical,
     // whether or not `charge_fee` is true.
@@ -564,7 +558,7 @@ fn test_simulate_validate_charge_fee_mid_execution(
         block_limit_fee,
         block_limit_fee,
     );
-    check_balance(current_balance, &mut state, account_address, chain_info, &fee_type, charge_fee);
+    check_balance(current_balance, &state, account_address, chain_info, &fee_type, charge_fee);
 }
 
 #[rstest]
@@ -652,14 +646,8 @@ fn test_simulate_validate_charge_fee_post_execution(
         if charge_fee { just_not_enough_fee_bound } else { unlimited_fee },
         if charge_fee { revert_fee } else { unlimited_fee },
     );
-    let current_balance = check_balance(
-        current_balance,
-        &mut state,
-        account_address,
-        chain_info,
-        &fee_type,
-        charge_fee,
-    );
+    let current_balance =
+        check_balance(current_balance, &state, account_address, chain_info, &fee_type, charge_fee);
 
     // Second scenario: balance too low.
     // Execute a transfer, and make sure we get the expected result.
@@ -724,7 +712,7 @@ fn test_simulate_validate_charge_fee_post_execution(
     );
     check_balance(
         current_balance,
-        &mut state,
+        &state,
         account_address,
         chain_info,
         &fee_type,