chore: cleanups of OUT_DIR env var (#2484)

commit-id:18d61b1d

crates/infra_utils/src/command.rs

@@ -25,5 +25,7 @@ pub fn create_shell_command(command_name: &str) -> Command {
     env::vars().filter(|(key, _)| key.starts_with("CARGO_")).for_each(|(key, _)| {
         command.env_remove(key);
     });
+    // Filter out (the potentially set) OUT_DIR environment variable.
+    command.env_remove("OUT_DIR");
     command
 }

crates/infra_utils/src/tracing_test.rs

@@ -99,7 +99,7 @@ struct MessageVisitor<'a> {
     message: &'a mut String,
 }
 
-impl<'a> Visit for MessageVisitor<'a> {
+impl Visit for MessageVisitor<'_> {
     fn record_debug(&mut self, field: &Field, value: &dyn Debug) {
         if field.name() == "message" {
             self.message.push_str(&format!("{:?}", value));

crates/starknet_sierra_compile/src/paths.rs

@@ -1,6 +1,6 @@
-// Note: This module includes constants that are needed during build and run times. It must
-// not contain functionality that is available in only in one of these modes. Specifically, it
-// must avoid relying on env variables such as 'CARGO_*' or 'OUT_DIR'.
+// Note: This module includes path resolution functions that are needed during build and run times.
+// It must not contain functionality that is available in only in one of these modes. Specifically,
+// it must avoid relying on env variables such as 'CARGO_*' or 'OUT_DIR'.
 
 fn target_dir(out_dir: std::path::PathBuf) -> std::path::PathBuf {
     out_dir