Skip to content

Commit

Permalink
chore(ci): use large_runner in committer (#378)
Browse files Browse the repository at this point in the history
* chore(ci): use large_runner in committer

* chore(ci): fix review comments
  • Loading branch information
alon-dotan-starkware authored Aug 18, 2024
1 parent 4d4094c commit 98cc463
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 9 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/blockifier_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ on:
# Other than code-related changes, all changes related to the native-blockifier build-and-push
# process should trigger the build (e.g., changes to the Dockerfile, build scripts, etc.).
- '.github/workflows/blockifier_ci.yml'
- 'Cargo.toml'
- 'build_native_in_docker.sh'
- 'Cargo.lock'
- 'build_native_blockifier_in_docker.sh'
- 'Cargo.toml'
- 'crates/blockifier/**'
- 'crates/native_blockifier/**'
- 'scripts/blockifier.Dockerfile'
- 'scripts/build_native_blockifier.sh'
- 'scripts/install_build_tools.sh'
- 'scripts/sequencer-ci.Dockerfile'

jobs:
featureless-build:
Expand All @@ -55,7 +55,7 @@ jobs:
prefix-key: "v1-rust-ubuntu-20.04"

- name: Build native blockifier
run: ./build_native_blockifier_in_docker.sh
run: ./build_native_in_docker.sh scripts/build_native_blockifier.sh

# Commit hash on pull request event would be the head commit of the branch.
- name: Get commit hash prefix for PR update
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/committer_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ jobs:
})
gcs-push:
runs-on: ubuntu-20.04
runs-on: starkware-ubuntu-20-04-medium
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/install_rust
Expand All @@ -135,7 +135,7 @@ jobs:
run: echo "SHORT_HASH=${COMMIT_SHA:0:7}" >> $GITHUB_ENV

- name: Build CLI binary
run: cargo build -p committer_cli -r --bin committer_cli --target-dir CLI_TARGET
run: ./build_native_in_docker.sh cargo build -p committer_cli -r --bin committer_cli --target-dir CLI_TARGET

- id: auth
uses: "google-github-actions/auth@v2"
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
# will have compiled files and executables
debug/
target/
ci/
CLI_TARGET/

# These are backup files generated by rustfmt
**/*.rs.bk
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
#!/bin/env bash
set -e

docker_image_name=blockifier-ci
docker_image_name=sequencer-ci

(
cd scripts
docker build . -t ${docker_image_name} --file blockifier.Dockerfile
docker build . -t ${docker_image_name} --file ${docker_image_name}.Dockerfile
)

docker run \
Expand All @@ -17,4 +17,4 @@ docker run \
-v "${HOME}:${HOME}" \
--workdir ${PWD} \
${docker_image_name} \
scripts/build_native_blockifier.sh
"$@"
File renamed without changes.

0 comments on commit 98cc463

Please sign in to comment.