chore: remove redundant crate dependency (#2195)

commit-id:5054ab86
starkware-libs · Nov 26, 2024 · a045ec8 · a045ec8
1 parent 8c9634a
commit a045ec8
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 17 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/papyrus_monitoring_gateway/Cargo.toml b/crates/papyrus_monitoring_gateway/Cargo.toml
@@ -22,7 +22,6 @@ tracing.workspace = true
 validator = { workspace = true, features = ["derive"] }
 
 [dev-dependencies]
-http-body.workspace = true
 metrics.workspace = true
 papyrus_storage = { workspace = true, features = ["testing"] }
 pretty_assertions.workspace = true

diff --git a/crates/papyrus_monitoring_gateway/src/gateway_test.rs b/crates/papyrus_monitoring_gateway/src/gateway_test.rs
@@ -5,7 +5,6 @@ use axum::body::Body;
 use axum::http::{Request, StatusCode};
 use axum::response::Response;
 use axum::Router;
-use http_body::combinators::UnsyncBoxBody;
 use metrics::{absolute_counter, describe_counter, register_counter};
 use metrics_exporter_prometheus::PrometheusBuilder;
 use papyrus_storage::{table_names, test_utils};
@@ -38,10 +37,7 @@ fn setup_app() -> Router {
     )
 }
 
-async fn request_app(
-    app: Router,
-    method: &str,
-) -> Response<UnsyncBoxBody<axum::body::Bytes, axum::Error>> {
+async fn request_app(app: Router, method: &str) -> Response {
     app.oneshot(
         Request::builder()
             .uri(format!("/{MONITORING_PREFIX}/{method}").as_str())

diff --git a/crates/starknet_monitoring_endpoint/Cargo.toml b/crates/starknet_monitoring_endpoint/Cargo.toml
@@ -9,14 +9,13 @@ license-file.workspace = true
 normal = ["tokio"]
 
 [features]
-testing = ["http-body", "tokio", "tower"]
+testing = ["tokio", "tower"]
 
 [lints]
 workspace = true
 
 [dependencies]
 axum.workspace = true
-http-body = { workspace = true, optional = true }
 hyper = { workspace = true }
 papyrus_config.workspace = true
 serde.workspace = true
@@ -27,7 +26,6 @@ tracing.workspace = true
 validator.workspace = true
 
 [dev-dependencies]
-http-body.workspace = true
 pretty_assertions.workspace = true
 tokio.workspace = true
 tower.workspace = true
diff --git a/crates/starknet_monitoring_endpoint/src/monitoring_endpoint_test.rs b/crates/starknet_monitoring_endpoint/src/monitoring_endpoint_test.rs
@@ -1,10 +1,8 @@
 use std::net::IpAddr;
 
-use axum::body::Bytes;
 use axum::http::StatusCode;
 use axum::response::Response;
-use axum::{Error, Router};
-use http_body::combinators::UnsyncBoxBody;
+use axum::Router;
 use hyper::body::to_bytes;
 use hyper::Client;
 use pretty_assertions::assert_eq;
@@ -28,7 +26,7 @@ fn setup_monitoring_endpoint() -> MonitoringEndpoint {
     create_monitoring_endpoint(MonitoringEndpointConfig::default(), TEST_VERSION)
 }
 
-async fn request_app(app: Router, method: &str) -> Response<UnsyncBoxBody<Bytes, Error>> {
+async fn request_app(app: Router, method: &str) -> Response {
     app.oneshot(build_request(&IpAddr::from([0, 0, 0, 0]), 0, method)).await.unwrap()
 }
 

diff --git a/crates/starknet_monitoring_endpoint/src/test_utils.rs b/crates/starknet_monitoring_endpoint/src/test_utils.rs
@@ -9,8 +9,6 @@ use tracing::info;
 
 use crate::monitoring_endpoint::{ALIVE, MONITORING_PREFIX};
 
-// TODO(Tsabary): try avoid having to use http-body crate from the dependencies.
-
 /// Client for querying 'alive' status of an http server.
 pub struct IsAliveClient {
     socket: SocketAddr,