feat(batcher): add validate flow request handlers

starkware-libs · Nov 4, 2024 · a399828 · a399828
1 parent bd3fad8
commit a399828
Show file tree

Hide file tree

Showing 4 changed files with 35 additions and 3 deletions.
diff --git a/crates/batcher/src/batcher.rs b/crates/batcher/src/batcher.rs
@@ -16,7 +16,10 @@ use starknet_batcher_types::batcher_types::{
     GetProposalContentInput,
     GetProposalContentResponse,
     ProposalId,
+    SendProposalContentInput,
+    SendProposalContentResponse,
     StartHeightInput,
+    ValidateProposalInput,
 };
 use starknet_batcher_types::errors::BatcherError;
 use starknet_mempool_types::communication::SharedMempoolClient;
@@ -99,6 +102,22 @@ impl Batcher {
         Ok(())
     }
 
+    #[instrument(skip(self), err)]
+    pub async fn validate_proposal(
+        &mut self,
+        validate_proposal_input: ValidateProposalInput,
+    ) -> BatcherResult<()> {
+        todo!();
+    }
+
+    #[instrument(skip(self), err)]
+    pub async fn send_proposal_content(
+        &mut self,
+        send_proposal_content_input: SendProposalContentInput,
+    ) -> BatcherResult<SendProposalContentResponse> {
+        todo!();
+    }
+
     #[instrument(skip(self), err)]
     pub async fn get_proposal_content(
         &mut self,

diff --git a/crates/batcher/src/communication.rs b/crates/batcher/src/communication.rs
@@ -35,7 +35,12 @@ impl ComponentRequestHandler<BatcherRequest, BatcherResponse> for Batcher {
             BatcherRequest::DecisionReached(input) => {
                 BatcherResponse::DecisionReached(self.decision_reached(input).await)
             }
-            _ => unimplemented!(),
+            BatcherRequest::ValidateProposal(input) => {
+                BatcherResponse::ValidateProposal(self.validate_proposal(input).await)
+            }
+            BatcherRequest::SendProposalContent(input) => {
+                BatcherResponse::SendProposalContent(self.send_proposal_content(input).await)
+            }
         }
     }
 }
diff --git a/crates/batcher_types/src/batcher_types.rs b/crates/batcher_types/src/batcher_types.rs
@@ -59,6 +59,7 @@ pub enum GetProposalContent {
 pub struct ValidateProposalInput {
     pub proposal_id: ProposalId,
     pub deadline: chrono::DateTime<Utc>,
+    pub retrospective_block_hash: Option<BlockHashAndNumber>,
 }
 
 impl BuildProposalInput {

diff --git a/crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs b/crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs
@@ -140,8 +140,15 @@ impl ConsensusContext for SequencerConsensusContext {
 
         let chrono_timeout =
             chrono::Duration::from_std(timeout).expect("Can't convert timeout to chrono::Duration");
-        let input =
-            ValidateProposalInput { proposal_id, deadline: chrono::Utc::now() + chrono_timeout };
+        let input = ValidateProposalInput {
+            proposal_id,
+            deadline: chrono::Utc::now() + chrono_timeout,
+            // TODO(Matan 3/11/2024): Add the real value of the retrospective block hash.
+            retrospective_block_hash: Some(BlockHashAndNumber {
+                number: BlockNumber::default(),
+                hash: BlockHash::default(),
+            }),
+        };
         self.maybe_start_height(height).await;
         batcher.validate_proposal(input).await.expect("Failed to initiate proposal validation");
         tokio::spawn(