chore: add a represantation of unxepected enum in client error (#158)

starkware-libs · Jul 29, 2024 · cbe5fb5 · cbe5fb5
1 parent 254c436
commit cbe5fb5
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 10 deletions.
diff --git a/crates/mempool_infra/src/component_client/definitions.rs b/crates/mempool_infra/src/component_client/definitions.rs
@@ -14,8 +14,8 @@ pub enum ClientError {
     ResponseParsingFailure(HyperError),
     #[error("Got status code: {0}, with server error: {1}")]
     ResponseError(StatusCode, ServerError),
-    #[error("Got an unexpected response type.")]
-    UnexpectedResponse,
+    #[error("Got an unexpected response type: {0}")]
+    UnexpectedResponse(String),
 }
 
 pub type ClientResult<T> = Result<T, ClientError>;
diff --git a/crates/mempool_infra/tests/component_server_client_http_test.rs b/crates/mempool_infra/tests/component_server_client_http_test.rs
@@ -72,14 +72,18 @@ impl ComponentBClientTrait for RemoteComponentClient<ComponentBRequest, Componen
     async fn b_get_value(&self) -> ResultB {
         match self.send(ComponentBRequest::BGetValue).await? {
             ComponentBResponse::BGetValue(value) => Ok(value),
-            _ => Err(ClientError::UnexpectedResponse),
+            unexpected_response => {
+                Err(ClientError::UnexpectedResponse(format!("{unexpected_response:?}")))
+            }
         }
     }
 
     async fn b_set_value(&self, value: ValueB) -> ClientResult<()> {
         match self.send(ComponentBRequest::BSetValue(value)).await? {
             ComponentBResponse::BSetValue => Ok(()),
-            _ => Err(ClientError::UnexpectedResponse),
+            unexpected_response => {
+                Err(ClientError::UnexpectedResponse(format!("{unexpected_response:?}")))
+            }
         }
     }
 }

diff --git a/crates/mempool_infra/tests/component_server_client_test.rs b/crates/mempool_infra/tests/component_server_client_test.rs
@@ -52,14 +52,18 @@ impl ComponentBClientTrait for LocalComponentClient<ComponentBRequest, Component
         let res = self.send(ComponentBRequest::BGetValue).await;
         match res {
             ComponentBResponse::BGetValue(value) => Ok(value),
-            _ => Err(ClientError::UnexpectedResponse),
+            unexpected_response => {
+                Err(ClientError::UnexpectedResponse(format!("{unexpected_response:?}")))
+            }
         }
     }
 
     async fn b_set_value(&self, value: ValueB) -> ClientResult<()> {
         match self.send(ComponentBRequest::BSetValue(value)).await {
             ComponentBResponse::BSetValue => Ok(()),
-            _ => Err(ClientError::UnexpectedResponse),
+            unexpected_response => {
+                Err(ClientError::UnexpectedResponse(format!("{unexpected_response:?}")))
+            }
         }
     }
 }

diff --git a/crates/mempool_types/src/communication.rs b/crates/mempool_types/src/communication.rs
@@ -62,7 +62,9 @@ impl MempoolClient for MempoolClientImpl {
             MempoolResponse::AddTransaction(Err(response)) => {
                 Err(MempoolClientError::MempoolError(response))
             }
-            _ => Err(MempoolClientError::ClientError(ClientError::UnexpectedResponse)),
+            unexpected_response => Err(MempoolClientError::ClientError(
+                ClientError::UnexpectedResponse(format!("{unexpected_response:?}")),
+            )),
         }
     }
 
@@ -74,7 +76,9 @@ impl MempoolClient for MempoolClientImpl {
             MempoolResponse::GetTransactions(Err(response)) => {
                 Err(MempoolClientError::MempoolError(response))
             }
-            _ => Err(MempoolClientError::ClientError(ClientError::UnexpectedResponse)),
+            unexpected_response => Err(MempoolClientError::ClientError(
+                ClientError::UnexpectedResponse(format!("{unexpected_response:?}")),
+            )),
         }
     }
 }
@@ -89,7 +93,9 @@ impl MempoolClient for RemoteMempoolClientImpl {
             MempoolResponse::AddTransaction(Err(response)) => {
                 Err(MempoolClientError::MempoolError(response))
             }
-            _ => Err(MempoolClientError::ClientError(ClientError::UnexpectedResponse)),
+            unexpected_response => Err(MempoolClientError::ClientError(
+                ClientError::UnexpectedResponse(format!("{unexpected_response:?}")),
+            )),
         }
     }
 
@@ -101,7 +107,9 @@ impl MempoolClient for RemoteMempoolClientImpl {
             MempoolResponse::GetTransactions(Err(response)) => {
                 Err(MempoolClientError::MempoolError(response))
             }
-            _ => Err(MempoolClientError::ClientError(ClientError::UnexpectedResponse)),
+            unexpected_response => Err(MempoolClientError::ClientError(
+                ClientError::UnexpectedResponse(format!("{unexpected_response:?}")),
+            )),
         }
     }
 }