Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(consensus): consensus takes a generic network receiver #112

Conversation

matan-starkware
Copy link
Contributor

@matan-starkware matan-starkware commented Jul 25, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information


This change is Reviewable

@matan-starkware matan-starkware marked this pull request as ready for review July 25, 2024 12:54
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/network_receiver_generic branch from 3396adf to eec4b9c Compare July 25, 2024 12:57
Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @asmaastarkware and @matan-starkware)

a discussion (no related file):
We plan to change those channels to Box<dyn Sink/Stream>, and then this PR will be unnecessary
@eitanm-starkware could you do that on Sunday?


@matan-starkware matan-starkware force-pushed the matan/consensus/m3/network_receiver_generic branch from eec4b9c to 7cbebd8 Compare July 29, 2024 16:58
@matan-starkware matan-starkware changed the base branch from main to matan/consensus/m3/test_network_receiver July 29, 2024 16:58
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/test_network_receiver branch from 2cf7254 to 5b593ff Compare July 30, 2024 07:06
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/network_receiver_generic branch from 7cbebd8 to f50d408 Compare July 30, 2024 07:06
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.72%. Comparing base (d166e52) to head (240bd76).

Additional details and impacted files
@@                            Coverage Diff                            @@
##           matan/consensus/m3/test_network_receiver     #112   +/-   ##
=========================================================================
  Coverage                                     76.72%   76.72%           
=========================================================================
  Files                                           311      311           
  Lines                                         34345    34345           
  Branches                                      34345    34345           
=========================================================================
  Hits                                          26352    26352           
+ Misses                                         5703     5702    -1     
- Partials                                       2290     2291    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

@matan-starkware matan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @asmaastarkware, @eitanm-starkware, and @ShahakShama)

a discussion (no related file):

Previously, ShahakShama wrote…

We plan to change those channels to Box<dyn Sink/Stream>, and then this PR will be unnecessary
@eitanm-starkware could you do that on Sunday?

As discussed your change is nothappening. Reviving.


@matan-starkware matan-starkware force-pushed the matan/consensus/m3/test_network_receiver branch from 5b593ff to 0bfd2bb Compare July 30, 2024 13:57
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/network_receiver_generic branch from f50d408 to 63a79b9 Compare July 30, 2024 13:57
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/test_network_receiver branch from 0bfd2bb to b138c57 Compare July 31, 2024 07:31
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/network_receiver_generic branch from 63a79b9 to 4d7d319 Compare July 31, 2024 07:31
Copy link
Contributor

@asmaastarkware asmaastarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @eitanm-starkware and @ShahakShama)

@matan-starkware matan-starkware force-pushed the matan/consensus/m3/test_network_receiver branch from b138c57 to 582a446 Compare July 31, 2024 12:29
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/network_receiver_generic branch from 4d7d319 to 69f6412 Compare July 31, 2024 12:29
Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @eitanm-starkware)

@matan-starkware matan-starkware force-pushed the matan/consensus/m3/test_network_receiver branch from 582a446 to d166e52 Compare July 31, 2024 14:22
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/network_receiver_generic branch from 69f6412 to 240bd76 Compare July 31, 2024 14:23
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/test_network_receiver branch from d166e52 to f5bb03a Compare August 1, 2024 08:55
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/network_receiver_generic branch from 240bd76 to e44b622 Compare August 1, 2024 08:55
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/test_network_receiver branch from f5bb03a to cff4d46 Compare August 1, 2024 10:18
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/network_receiver_generic branch from e44b622 to 58392fa Compare August 1, 2024 10:18
@matan-starkware matan-starkware deleted the branch matan/consensus/m3/test_network_receiver August 1, 2024 10:27
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants