refactor(blockifier): native syscall handler new method params

[rodrigo-pino]

This change is 

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 67.34%. Comparing base (e3165c4) to head (e203e9f).
Report is 34 commits behind head on main.

Files with missing lines	Patch %	Lines
...fier/src/execution/native/entry_point_execution.rs	0.00%	10 Missing ⚠️
...blockifier/src/execution/native/syscall_handler.rs	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1380       +/-   ##
===========================================
+ Coverage   40.10%   67.34%   +27.23%     
===========================================
  Files          26      102       +76     
  Lines        1895    13690    +11795     
  Branches     1895    13690    +11795     
===========================================
+ Hits          760     9219     +8459     
- Misses       1100     4070     +2970     
- Partials       35      401      +366     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[noaov1]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @rodrigo-pino)

---

crates/blockifier/src/execution/native/entry_point_execution.rs line 29 at r1 (raw file):

    let syscall_handler: NativeSyscallHandler<'_> =
        NativeSyscallHandler::new(&call, state, resources, context);

Suggestion:

        NativeSyscallHandler::new(call, state, resources, context);

---

crates/blockifier/src/execution/native/entry_point_execution.rs line 32 at r1 (raw file):

    run_native_executor(&contract_class.executor, function_id, call, syscall_handler)
}

Suggestion:

    run_native_executor(&contract_class.executor, function_id, syscall_handler)
}

---

crates/blockifier/src/execution/native/entry_point_execution.rs line 38 at r1 (raw file):

    function_id: FunctionId,
    call: CallEntryPoint,
    mut syscall_handler: NativeSyscallHandler<'_>,

Can you use the call in the syscall handler? (see my suggestion below)

Suggestion:

fn run_native_executor(
    native_executor: &AotNativeExecutor,
    function_id: FunctionId,
    mut syscall_handler: NativeSyscallHandler<'_>,

---

crates/blockifier/src/execution/native/entry_point_execution.rs line 65 at r1 (raw file):

    call: CallEntryPoint,
    call_result: ContractExecutionResult,
    syscall_handler: NativeSyscallHandler<'_>,

Suggestion:

fn create_callinfo(
    call_result: ContractExecutionResult,
    syscall_handler: NativeSyscallHandler<'_>,

---

crates/blockifier/src/execution/native/syscall_handler.rs line 34 at r1 (raw file):

    pub caller_address: ContractAddress,
    pub contract_address: ContractAddress,
    pub entry_point_selector: Felt,

Suggestion:

    pub context: &'state mut EntryPointExecutionContext,
    pub call: CallEntryPoint

[rodrigo-pino]

Reviewable status: 0 of 2 files reviewed, 5 unresolved discussions (waiting on @noaov1)

---

crates/blockifier/src/execution/native/entry_point_execution.rs line 29 at r1 (raw file):

    let syscall_handler: NativeSyscallHandler<'_> =
        NativeSyscallHandler::new(&call, state, resources, context);

Done.

---

crates/blockifier/src/execution/native/entry_point_execution.rs line 32 at r1 (raw file):

    run_native_executor(&contract_class.executor, function_id, call, syscall_handler)
}

Done.

---

crates/blockifier/src/execution/native/entry_point_execution.rs line 38 at r1 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Can you use the call in the syscall handler? (see my suggestion below)

Done.

---

crates/blockifier/src/execution/native/entry_point_execution.rs line 65 at r1 (raw file):

    call: CallEntryPoint,
    call_result: ContractExecutionResult,
    syscall_handler: NativeSyscallHandler<'_>,

Done.

---

crates/blockifier/src/execution/native/syscall_handler.rs line 34 at r1 (raw file):

    pub caller_address: ContractAddress,
    pub contract_address: ContractAddress,
    pub entry_point_selector: Felt,

Done.

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[noaov1]

Reviewed 1 of 2 files at r3, 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @rodrigo-pino)