-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: clippy error, whitelist blocks_in_conditions #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @alon-dotan-starkware, @dafnamatsry, @dan-starkware, and @elintul)
scripts/clippy.sh
line 3 at r1 (raw file):
#!/bin/bash cargo clippy "$@" --all-targets --all-features -- -Aclippy::blocks_in_conditions
many papyrus failures without this allow
; @dan-starkware can /should this allow
be kept? if not please assign someone to get this removed and pass clippy..
Code quote:
-- -Aclippy::blocks_in_conditions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alon-dotan-starkware, @dafnamatsry, and @dan-starkware)
fa5aedc
to
8cbac85
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
=======================================
Coverage 76.85% 76.85%
=======================================
Files 263 263
Lines 31672 31673 +1
Branches 31672 31673 +1
=======================================
+ Hits 24340 24342 +2
- Misses 5136 5137 +1
+ Partials 2196 2194 -2 ☔ View full report in Codecov by Sentry. |
1901d7b
to
eff427d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alon-dotan-starkware and @dan-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alon-dotan-starkware and @dan-starkware)
Signed-off-by: Dori Medini <dori@starkware.co>
eff427d
to
acae812
Compare
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information
This change is