Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use fully-qualifier derive_more, for disambiguation #1452

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

elintul
Copy link
Collaborator

@elintul elintul commented Oct 15, 2024

No description provided.

@lotem-starkware
Copy link
Contributor

This change is Reviewable

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 38.88889% with 11 lines in your changes missing coverage. Please review.

Project coverage is 68.54%. Comparing base (b0cfe82) to head (8674071).
Report is 431 commits behind head on main.

Files with missing lines Patch % Lines
crates/starknet_api/src/core.rs 37.50% 5 Missing ⚠️
crates/papyrus_network/src/sqmr/mod.rs 0.00% 2 Missing ⚠️
crates/starknet_api/src/block.rs 0.00% 2 Missing ⚠️
crates/batcher_types/src/batcher_types.rs 0.00% 1 Missing ⚠️
crates/starknet_api/src/transaction.rs 75.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (b0cfe82) and HEAD (8674071). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (b0cfe82) HEAD (8674071)
3 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1452      +/-   ##
==========================================
- Coverage   74.18%   68.54%   -5.65%     
==========================================
  Files         359      206     -153     
  Lines       36240    25364   -10876     
  Branches    36240    25364   -10876     
==========================================
- Hits        26886    17386    -9500     
+ Misses       7220     6716     -504     
+ Partials     2134     1262     -872     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ayeletstarkware ayeletstarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MohammadNassar1)

@elintul elintul merged commit 1501fc0 into main Oct 20, 2024
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants