Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(blockifier): structured cairo1 stack trace #1461

Merged
merged 1 commit into from
Oct 22, 2024
Merged

feat(blockifier): structured cairo1 stack trace #1461

merged 1 commit into from
Oct 22, 2024

Conversation

dorimedini-starkware
Copy link
Collaborator

No description provided.

@lotem-starkware
Copy link
Contributor

This change is Reviewable

This was referenced Oct 19, 2024
Merged
Merged
@dorimedini-starkware Graphite App
Copy link
Collaborator Author

dorimedini-starkware commented Oct 19, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Oct 19, 2024
Merged
Merged
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review October 19, 2024 16:43
@dorimedini-starkware dorimedini-starkware self-assigned this Oct 19, 2024
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from bc6318a to df2cd9d Compare October 19, 2024 16:54
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_structured_cairo1_stack_trace branch from 01a118d to 70b3dea Compare October 19, 2024 16:54
@codecov Codecov
Copy link

codecov bot commented Oct 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.28%. Comparing base (e3165c4) to head (c0023dc).
Report is 8 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #1461       +/-   ##
===========================================
+ Coverage   40.10%   67.28%   +27.18%     
===========================================
  Files          26      102       +76     
  Lines        1895    13701    +11806     
  Branches     1895    13701    +11806     
===========================================
+ Hits          760     9219     +8459     
- Misses       1100     4081     +2981     
- Partials       35      401      +366

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from df2cd9d to c0a1bcc Compare October 20, 2024 07:22
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_structured_cairo1_stack_trace branch from 70b3dea to 79554b8 Compare October 20, 2024 07:22
Yoni-Starkware
Yoni-Starkware reviewed Oct 20, 2024
View reviewed changes
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from c0a1bcc to 2f01bf1 Compare October 20, 2024 07:48
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_structured_cairo1_stack_trace branch from 79554b8 to 80f7337 Compare October 20, 2024 07:49
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from 2f01bf1 to 2976b8f Compare October 20, 2024 09:22
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_structured_cairo1_stack_trace branch from 80f7337 to 925040d Compare October 20, 2024 09:22
This was referenced Oct 20, 2024
Merged
Merged
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from 2976b8f to eb2ede4 Compare October 20, 2024 09:37
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_structured_cairo1_stack_trace branch from 925040d to 99eea64 Compare October 20, 2024 09:37
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from eb2ede4 to ae4ddcf Compare October 20, 2024 10:05
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_structured_cairo1_stack_trace branch from 99eea64 to a94d27b Compare October 20, 2024 10:05
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from ae4ddcf to 56b3ad1 Compare October 20, 2024 14:38
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_structured_cairo1_stack_trace branch from a94d27b to cb1ae57 Compare October 20, 2024 14:38
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from 56b3ad1 to a07521d Compare October 20, 2024 15:02
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_structured_cairo1_stack_trace branch from cb1ae57 to 276265c Compare October 20, 2024 15:02
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from aa3485b to b720ffa Compare October 21, 2024 19:20
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_structured_cairo1_stack_trace branch from 4f40e94 to f95eedb Compare October 21, 2024 19:20
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from b720ffa to 5e0478c Compare October 22, 2024 08:40
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_structured_cairo1_stack_trace branch from f95eedb to 335bff4 Compare October 22, 2024 08:41
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from 5e0478c to d70ede1 Compare October 22, 2024 08:48
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_structured_cairo1_stack_trace branch from 335bff4 to 3ec8e61 Compare October 22, 2024 08:48
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from d70ede1 to 2881004 Compare October 22, 2024 09:13
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_structured_cairo1_stack_trace branch from 3ec8e61 to 93ed1ae Compare October 22, 2024 09:13
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from 2881004 to 6d58105 Compare October 22, 2024 09:31
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_structured_cairo1_stack_trace branch from 93ed1ae to 69c658c Compare October 22, 2024 09:31
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from 6d58105 to 84e46f4 Compare October 22, 2024 11:51
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_structured_cairo1_stack_trace branch from 69c658c to 14270b1 Compare October 22, 2024 11:51
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch 2 times, most recently from bfa7ce4 to 147843a Compare October 22, 2024 12:55
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_structured_cairo1_stack_trace branch from 14270b1 to 68b1189 Compare October 22, 2024 12:55
ilyalesokhin-starkware
ilyalesokhin-starkware approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 3 files at r1, 1 of 3 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware)

@dorimedini-starkware dorimedini-starkware changed the base branch from 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace to graphite-base/1461 October 22, 2024 13:59
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_structured_cairo1_stack_trace branch from 68b1189 to 2e6d7fb Compare October 22, 2024 14:00
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/1461 to main October 22, 2024 14:00
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_structured_cairo1_stack_trace branch from 2e6d7fb to c0023dc Compare October 22, 2024 14:00
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

Yoni-Starkware
Yoni-Starkware approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware merged commit 1ef3528 into main Oct 22, 2024
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Yoni-Starkware Yoni-Starkware Yoni-Starkware approved these changes

@ilyalesokhin-starkware ilyalesokhin-starkware ilyalesokhin-starkware approved these changes

Assignees

@dorimedini-starkware dorimedini-starkware

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dorimedini-starkware @lotem-starkware @ilyalesokhin-starkware @Yoni-Starkware