Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move lld installation #1568

Merged
merged 1 commit into from
Oct 27, 2024
Merged

fix: move lld installation #1568

merged 1 commit into from
Oct 27, 2024

Conversation

giladchase
Copy link
Contributor

It is essential for our linux env, otherwise linking won't work.

It is essential for our linux env, otherwise linking won't work.
@giladchase giladchase requested a review from noaov1 October 27, 2024 10:25
@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @giladchase)

Copy link

Artifacts upload triggered. View details here

@giladchase giladchase merged commit 0ae5753 into main Oct 27, 2024
22 checks passed
@giladchase giladchase deleted the gilad/move-lld-installation branch October 27, 2024 12:04
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants