-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use BlockHashAndNumber from SN_API in blockifier #1616
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @dan-starkware and the rest of your teammates on Graphite |
Artifacts upload triggered. View details here |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1616 +/- ##
===========================================
+ Coverage 40.10% 76.95% +36.84%
===========================================
Files 26 360 +334
Lines 1895 38359 +36464
Branches 1895 38359 +36464
===========================================
+ Hits 760 29519 +28759
- Misses 1100 6607 +5507
- Partials 35 2233 +2198 ☔ View full report in Codecov by Sentry. |
2dd48d7
to
2487598
Compare
Artifacts upload triggered. View details here |
2487598
to
e5e2d26
Compare
Artifacts upload triggered. View details here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 12 of 14 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware)
crates/blockifier/src/test_utils.rs
line 465 at r2 (raw file):
} pub fn maybe_dummy_block_hash_and_number(block_number: BlockNumber) -> Option<BlockHashAndNumber> {
Why maybe?
We usually add such methods in the struct_impl
file. Do you think that adding it here is better?
Code quote:
pub fn maybe_dummy_block_hash_and_number(block_number: BlockNumber) -> Option<BlockHashAndNumber> {
No description provided.