Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use BlockHashAndNumber from SN_API in blockifier #1616

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

dan-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dan-starkware and the rest of your teammates on Graphite Graphite

@dan-starkware dan-starkware requested a review from noaov1 October 28, 2024 14:21
Copy link

Artifacts upload triggered. View details here

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.95%. Comparing base (e3165c4) to head (e5e2d26).
Report is 77 commits behind head on main.

Files with missing lines Patch % Lines
crates/native_blockifier/src/py_utils.rs 20.00% 2 Missing and 2 partials ⚠️
crates/blockifier/src/blockifier/block.rs 75.00% 0 Missing and 1 partial ⚠️
crates/papyrus_execution/src/lib.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1616       +/-   ##
===========================================
+ Coverage   40.10%   76.95%   +36.84%     
===========================================
  Files          26      360      +334     
  Lines        1895    38359    +36464     
  Branches     1895    38359    +36464     
===========================================
+ Hits          760    29519    +28759     
- Misses       1100     6607     +5507     
- Partials       35     2233     +2198     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dan-starkware dan-starkware force-pushed the dan/misc/hash_and_number03 branch from 2dd48d7 to 2487598 Compare October 28, 2024 14:46
Copy link

Artifacts upload triggered. View details here

@dan-starkware dan-starkware marked this pull request as ready for review October 29, 2024 09:47
@dan-starkware dan-starkware force-pushed the dan/misc/hash_and_number03 branch from 2487598 to e5e2d26 Compare October 29, 2024 10:04
Copy link

Artifacts upload triggered. View details here

Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 12 of 14 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware)


crates/blockifier/src/test_utils.rs line 465 at r2 (raw file):

}

pub fn maybe_dummy_block_hash_and_number(block_number: BlockNumber) -> Option<BlockHashAndNumber> {

Why maybe?
We usually add such methods in the struct_impl file. Do you think that adding it here is better?

Code quote:

pub fn maybe_dummy_block_hash_and_number(block_number: BlockNumber) -> Option<BlockHashAndNumber> {

@dan-starkware dan-starkware merged commit ee6513d into main Oct 30, 2024
22 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants