refactor(execution): put all create for testing methods under testing…

[meship-starkware]

… config

refactor(execution): put all create for testing methods under testing config

---

This change is 

[graphite-app]

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (07/29/24)

1 reviewer was added to this PR based on 's automation.

[meship-starkware]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @noaov1)

a discussion (no related file):
@tdelabro

---

[noaov1]

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @meship-starkware)

---

crates/blockifier/src/transaction/transactions.rs line 514 at r2 (raw file):

    #[cfg(any(test, feature = "testing"))]
    pub fn create_for_testing(l1_fee: Fee, contract_address: ContractAddress) -> Self {

Please move it to struct_impl

Code quote:

    #[cfg(any(test, feature = "testing"))]
    pub fn create_for_testing(l1_fee: Fee, contract_address: ContractAddress) -> Self {

---

crates/gateway/src/config.rs line 212 at r2 (raw file):

#[cfg(any(test, feature = "testing"))]
impl ChainInfoConfig {
    pub fn create_for_testing() -> Self {

Same below

Suggestion:

impl ChainInfoConfig {
    #[cfg(any(test, feature = "testing"))]
    pub fn create_for_testing() -> Self {

[meship-starkware]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @noaov1)

---

crates/blockifier/src/transaction/transactions.rs line 514 at r2 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Please move it to struct_impl

Do we want all impl L1HandlerTransaction to only appear in tests binary?

---

crates/gateway/src/config.rs line 212 at r2 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Same below

Do you want me to mark the configuration only for the function?

[noaov1]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @meship-starkware)

---

crates/blockifier/src/transaction/transactions.rs line 514 at r2 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

Do we want all impl L1HandlerTransaction to only appear in tests binary?

No, only the create_for_testing method

[meship-starkware]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @noaov1)

---

crates/gateway/src/config.rs line 212 at r2 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

Do you want me to mark the configuration only for the function?

I can't do this because it is a part of the gateway crate and not the blockifier.

[meship-starkware]

Reviewable status: 1 of 3 files reviewed, 3 unresolved discussions (waiting on @noaov1)

---

crates/blockifier/src/transaction/transactions.rs line 514 at r2 (raw file):

Previously, noaov1 (Noa Oved) wrote…

No, only the create_for_testing method

Done.

[noaov1]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @meship-starkware)

---

crates/gateway/src/config.rs line 212 at r2 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

I can't do this because it is a part of the gateway crate and not the blockifier.

Can you please elaborate?

[meship-starkware]

Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @noaov1)

---

crates/gateway/src/config.rs line 212 at r2 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Can you please elaborate?

Nevermind I did not understand the remark
Done.

[noaov1]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @meship-starkware)

---

crates/gateway/src/config.rs line 210 at r4 (raw file):

    }
}
impl ChainInfoConfig {

Suggestion:

}

impl ChainInfoConfig {

---

crates/gateway/src/config.rs line 290 at r4 (raw file):

#[cfg(any(test, feature = "testing"))]
impl StatefulTransactionValidatorConfig {
    pub fn create_for_testing() -> Self {

Suggestion:

impl StatefulTransactionValidatorConfig {
    #[cfg(any(test, feature = "testing"))]
    pub fn create_for_testing() -> Self {

[meship-starkware]

Reviewable status: 1 of 3 files reviewed, 3 unresolved discussions (waiting on @noaov1)

---

crates/gateway/src/config.rs line 210 at r4 (raw file):

    }
}
impl ChainInfoConfig {

Done.

---

crates/gateway/src/config.rs line 290 at r4 (raw file):

#[cfg(any(test, feature = "testing"))]
impl StatefulTransactionValidatorConfig {
    pub fn create_for_testing() -> Self {

Done.

[noaov1]

Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1)