Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge main-v0.13.2 into main #169

Merged
merged 13 commits into from
Jul 29, 2024
Merged

Merge main-v0.13.2 into main #169

merged 13 commits into from
Jul 29, 2024

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Jul 29, 2024 •
edited by alon-dotan-starkware
Loading

This change is Reviewable

dorimedini-starkware and others added 12 commits July 25, 2024 18:13
@dorimedini-starkware
fix: global file changes trigger specific package CIs (#77)
5eb8cdc 
Signed-off-by: Dori Medini <dori@starkware.co>
@dan-starkware
chore(ci): allow warning during cargo doc (#127)
6c916db
@dan-starkware
chore: fix some clippy doc issues (#122)
3f13669
@dan-starkware
chore(ci): fix package selection (#123)
a848403
@dan-starkware
chore(ci): add triggers to papyrus ci (#121)
e12ba1c
@dan-starkware
ci: add triggers for papyrus CI (#135)
a8c358e
@dorimedini-starkware
chore(ci): fix merge paths CI (#116)
cd76a9f 
Signed-off-by: Dori Medini <dori@starkware.co>
@aner-starkware
refactor: move test files to dedicated directory (#105)
d3a61b4
@dorimedini-starkware
chore: move (workspace) doc test to main (workspace) CI (#106)
5d63dc5 
Signed-off-by: Dori Medini <dori@starkware.co>
@aner-starkware
fix: restore ci (#107)
794869b
@meship-starkware
fix(execution): forbid calling cairo0 contract with cairo1 only built…
7ee04db 
…ins (#128)
@dorimedini-starkware
chore: merge branch main-v0.13.2 into main (with conflicts)
3014399
@dorimedini-starkware
Copy link
Collaborator Author

Src Dst .github/workflows/committer_ci.yml
Src Dst crates/sequencing/papyrus_consensus/src/state_machine.rs

@dorimedini-starkware dorimedini-starkware self-assigned this Jul 29, 2024
dorimedini-starkware
dorimedini-starkware commented Jul 29, 2024
View reviewed changes
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r11, 15 of 15 files at r12, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware
fix: conflict resolution
443e717 
Signed-off-by: Dori Medini <dori@starkware.co>
@github-actions GitHub Actions
Copy link

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.228 ms 34.624 ms 35.062 ms]
change: [+2.4481% +3.5795% +4.8204%] (p = 0.00 < 0.05)
Performance has regressed.
Found 9 outliers among 100 measurements (9.00%)
7 (7.00%) high mild
2 (2.00%) high severe

asmaastarkware
asmaastarkware approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@asmaastarkware asmaastarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: from consensus review

Reviewed 2 of 2 files at r13, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aner-starkware and @TzahiTaub)

dorimedini-starkware
dorimedini-starkware commented Jul 29, 2024
View reviewed changes
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aner-starkware and @TzahiTaub)

@dorimedini-starkware dorimedini-starkware merged commit 0aa3f9a into main Jul 29, 2024
23 of 24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@asmaastarkware asmaastarkware asmaastarkware approved these changes

@TzahiTaub TzahiTaub Awaiting requested review from TzahiTaub

@aner-starkware aner-starkware Awaiting requested review from aner-starkware

Assignees

@dorimedini-starkware dorimedini-starkware

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dorimedini-starkware @asmaastarkware @dan-starkware @aner-starkware @meship-starkware