chore(blockifier): alternate use of casm and native depending on tracked_resource

[avivg-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload triggered. View details here

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.09%. Comparing base (e3165c4) to head (5f0517d).
Report is 123 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1699       +/-   ##
===========================================
+ Coverage   40.10%   69.09%   +28.99%     
===========================================
  Files          26      100       +74     
  Lines        1895    13449    +11554     
  Branches     1895    13449    +11554     
===========================================
+ Hits          760     9293     +8533     
- Misses       1100     3754     +2654     
- Partials       35      402      +367     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[noaov1]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avivg-starkware)

---

crates/blockifier/src/execution/execution_utils.rs line 145 at r1 (raw file):

        #[cfg(feature = "cairo_native")]
        ContractClass::V1Native(contract_class) => {
            if context.tracked_resource_stack.last() == Some(&TrackedResource::CairoSteps) {

Please add a doc explaining this behaviour.

Code quote:

if context.tracked_resource_stack.last() == Some(&TrackedResource::CairoSteps) {

[avivg-starkware]

crates/blockifier/src/execution/execution_utils.rs line 145 at r1 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Please add a doc explaining this behaviour.

added, WDYT?

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[avivg-starkware]

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1)

[noaov1]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avivg-starkware)

---

crates/blockifier/src/execution/execution_utils.rs line 147 at r2 (raw file):

            if context.tracked_resource_stack.last() == Some(&TrackedResource::CairoSteps) {
                // if CairoSteps are tracked instead of SierraGas, use Casm for all following
                // calling txs.

Suggestion:

            // We cannot run native with cairo steps as the tracked resources (it's a vm resouorce).
            if context.tracked_resource_stack.last() == Some(&TrackedResource::CairoSteps) {

[avivg-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1)

---

crates/blockifier/src/execution/execution_utils.rs line 147 at r2 (raw file):

            if context.tracked_resource_stack.last() == Some(&TrackedResource::CairoSteps) {
                // if CairoSteps are tracked instead of SierraGas, use Casm for all following
                // calling txs.

Done.

[github-actions]

Artifacts upload triggered. View details here

[avivg-starkware]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1)

[noaov1]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)