test(blockifier): execute_directly with v3 invoke instead of deprecated

[TzahiTaub]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[dorimedini-starkware]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TzahiTaub)

---

crates/blockifier/src/test_utils/struct_impls.rs line 58 at r1 (raw file):

        let default_invoke_tx = account_invoke_tx(InvokeTxArgs::default());
        let tx_info = default_invoke_tx.create_tx_info();
        assert!(matches!(tx_info, TransactionInfo::Current(_)));

this is an awkward way to get the desired default tx context...
maybe add a &TransactionInfo input to this method? is it possible?

Code quote:

        let limit_steps_by_resources = false;
        let default_invoke_tx = account_invoke_tx(InvokeTxArgs::default());
        let tx_info = default_invoke_tx.create_tx_info();
        assert!(matches!(tx_info, TransactionInfo::Current(_)));

[TzahiTaub]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

crates/blockifier/src/test_utils/struct_impls.rs line 58 at r1 (raw file):

Previously, dorimedini-starkware wrote…

this is an awkward way to get the desired default tx context...
maybe add a &TransactionInfo input to this method? is it possible?

But I want to save the callers this boilerplate code

[github-actions]

Artifacts upload triggered. View details here

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.54%. Comparing base (e3165c4) to head (a20c055).
Report is 213 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1770       +/-   ##
===========================================
+ Coverage   40.10%   68.54%   +28.43%     
===========================================
  Files          26      102       +76     
  Lines        1895    13625    +11730     
  Branches     1895    13625    +11730     
===========================================
+ Hits          760     9339     +8579     
- Misses       1100     3885     +2785     
- Partials       35      401      +366     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dorimedini-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TzahiTaub)

---

crates/blockifier/src/test_utils/struct_impls.rs line 58 at r1 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

But I want to save the callers this boilerplate code

add CurrentTransactionInfo::default_for_testing

[TzahiTaub]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @TzahiTaub)

---

crates/blockifier/src/test_utils/struct_impls.rs line 58 at r1 (raw file):

Previously, dorimedini-starkware wrote…

add CurrentTransactionInfo::default_for_testing

Done.

[github-actions]

Artifacts upload triggered. View details here

[dorimedini-starkware]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TzahiTaub)

---

crates/blockifier/src/transaction/objects.rs line 126 at r2 (raw file):

        Self {
            common_fields: CommonAccountFields::default(),
            resource_bounds: ValidResourceBounds::create_for_testing(),

this gives AllResources that are nonzero, right?

Code quote:

ValidResourceBounds::create_for_testing()

[TzahiTaub]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

crates/blockifier/src/transaction/objects.rs line 126 at r2 (raw file):

Previously, dorimedini-starkware wrote…

this gives AllResources that are nonzero, right?

GasAmount for L2 is high, price is 0, and for the other two, amount is 1 and price is 0. This is to keep enforce_fee==False.

[dorimedini-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[TzahiTaub]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)