Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config): avoid using macro to enable formatter #1776

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware commented Nov 3, 2024

commit-id:73b9f196


Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 96.22642% with 4 lines in your changes missing coverage. Please review.

Project coverage is 9.08%. Comparing base (e3165c4) to head (e1f8395).
Report is 196 commits behind head on main.

Files with missing lines Patch % Lines
crates/papyrus_config/src/dumping.rs 94.87% 0 Missing and 2 partials ⚠️
crates/papyrus_node/src/bin/papyrus_dump_config.rs 0.00% 1 Missing ⚠️
...es/sequencer_node/src/bin/sequencer_dump_config.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #1776       +/-   ##
==========================================
- Coverage   40.10%   9.08%   -31.03%     
==========================================
  Files          26     288      +262     
  Lines        1895   32921    +31026     
  Branches     1895   32921    +31026     
==========================================
+ Hits          760    2991     +2231     
- Misses       1100   29708    +28608     
- Partials       35     222      +187     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yair-starkware yair-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from spr/main/e4597e85 to main November 5, 2024 11:15
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware merged commit b20329c into main Nov 5, 2024
17 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants