Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(execution): add workspace lints #1794

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

giladchase
Copy link
Contributor

Lior banned as repo-wide, unless absolutely necessary.

Nearly all as uses can be replaced with [Try]From which doesn't have implicit coercions like as (we encountered several bugs due to these coercions).

Motivation: we are standardizing lints across the repo and CI, instead of each crate having separate sets of lints.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.41%. Comparing base (e3165c4) to head (5d4b900).
Report is 197 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1794      +/-   ##
==========================================
- Coverage   40.10%   38.41%   -1.70%     
==========================================
  Files          26      110      +84     
  Lines        1895    15735   +13840     
  Branches     1895    15735   +13840     
==========================================
+ Hits          760     6044    +5284     
- Misses       1100     9022    +7922     
- Partials       35      669     +634     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @giladchase and @yair-starkware)


crates/papyrus_execution/src/objects.rs line 372 at r1 (raw file):

            continue;
        }
        let count: u64 = u64_from_usize(count);

non-blocking

Suggestion:

let count = u64_from_usize(count);

@giladchase giladchase force-pushed the gilad/gilad/reexecution-lints branch from b692605 to 284bae1 Compare November 5, 2024 08:37
@giladchase giladchase changed the title chore(reexecution): add workspace lints chore(execution): add workspace lints Nov 5, 2024
Lior banned `as` repo-wide, unless absolutely necessary.

Nearly all as uses can be replaced with [Try]From which doesn't
have implicit coercions like as (we encountered several bugs due to these coercions).

Motivation: we are standardizing lints across the repo and CI,
instead of each crate having separate sets of lints.
@giladchase giladchase force-pushed the gilad/gilad/reexecution-lints branch from 284bae1 to 5d4b900 Compare November 5, 2024 11:02
Copy link
Contributor Author

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)

@giladchase giladchase merged commit 2c166ff into main Nov 5, 2024
17 checks passed
@giladchase giladchase deleted the gilad/gilad/reexecution-lints branch November 5, 2024 11:55
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants