feat(blockifier): add get_execution_info_v2 syscall

[varex83]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload triggered. View details here

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.12%. Comparing base (e3165c4) to head (8f17982).
Report is 403 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/starknet_api/src/data_availability.rs	0.00%	5 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1812       +/-   ##
===========================================
+ Coverage   40.10%   77.12%   +37.02%     
===========================================
  Files          26      105       +79     
  Lines        1895    13663    +11768     
  Branches     1895    13663    +11768     
===========================================
+ Hits          760    10538     +9778     
- Misses       1100     2667     +1567     
- Partials       35      458      +423     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[meship-starkware]

Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @noaov1 and @varex83)

---

crates/blockifier/src/execution/native/syscall_handler.rs line 203 at r1 (raw file):

                paymaster_data: context.paymaster_data.0.clone(),
                nonce_data_availability_mode: context.nonce_data_availability_mode as u32,
                fee_data_availability_mode: context.fee_data_availability_mode as u32,

Please use into or try_ino and not as

Suggestion:

                nonce_data_availability_mode: context.nonce_data_availability_mode.into(),
                fee_data_availability_mode: context.fee_data_availability_mode.into(),

[varex83]

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @meship-starkware and @noaov1)

---

crates/blockifier/src/execution/native/syscall_handler.rs line 203 at r1 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

Please use into or try_ino and not as

TryInto is not implemented in this case for the enum, but corresponding integers are defined in the enum itself, so converting with as is a pretty idiomatic way to do

[varex83]

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @meship-starkware and @noaov1)

---

crates/blockifier/src/execution/native/syscall_handler.rs line 203 at r1 (raw file):

Previously, varex83 (Bohdan Ohorodnii) wrote…

TryInto is not implemented in this case for the enum, but corresponding integers are defined in the enum itself, so converting with as is a pretty idiomatic way to do

Oh, just noticed that clippy failed (I was checking it a few times, but only now it appeared). I will push fix ASAP

[github-actions]

Artifacts upload triggered. View details here

[meship-starkware]

Reviewed 1 of 2 files at r2.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @noaov1 and @varex83)

---

crates/blockifier/src/execution/native/syscall_handler.rs line 20 at r1 (raw file):

use starknet_types_core::felt::Felt;

use super::utils::{calculate_resource_bounds, default_tx_v2_info};

Avoid using super

Code quote:

use super::utils::{calculate_resource_bounds, default_tx_v2_info};

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[varex83]

Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @meship-starkware and @noaov1)

---

crates/blockifier/src/execution/native/syscall_handler.rs line 20 at r1 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

Avoid using super

Done

[github-actions]

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.101 ms 34.639 ms 35.273 ms]
change: [+1.2606% +2.8239% +4.7791%] (p = 0.00 < 0.05)
Performance has regressed.
Found 11 outliers among 100 measurements (11.00%)
2 (2.00%) high mild
9 (9.00%) high severe

[meship-starkware]

Reviewed 1 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

[github-actions]

Artifacts upload triggered. View details here

[meship-starkware]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.636 ms 34.722 ms 34.809 ms]
change: [-5.2677% -3.6098% -2.1573%] (p = 0.00 < 0.05)
Performance has improved.

[meship-starkware]

Reviewed 1 of 1 files at r8, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1 and @Yoni-Starkware)

[meship-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1 and @Yoni-Starkware)

[github-actions]

Artifacts upload triggered. View details here

[meship-starkware]

Reviewed 1 of 1 files at r9, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1 and @Yoni-Starkware)

[avi-starkware]

Reviewed 1 of 2 files at r2, 2 of 4 files at r6, 1 of 1 files at r7, 1 of 1 files at r8.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1 and @Yoni-Starkware)

[github-actions]

Artifacts upload triggered. View details here

[Yoni-Starkware]

Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @meship-starkware, @noaov1, and @varex83)

---

crates/blockifier/src/execution/native/utils.rs line 72 at r10 (raw file):

                },
                ResourceBounds {
                    resource: Felt::from_hex(Resource::L1DataGas.to_hex()).unwrap(),

I think this is the wrong order. Please check against the vm impl

[varex83]

Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @meship-starkware, @noaov1, and @Yoni-Starkware)

---

crates/blockifier/src/execution/native/utils.rs line 72 at r10 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

I think this is the wrong order. Please check against the vm impl

Done.

[github-actions]

Artifacts upload triggered. View details here

[Yoni-Starkware]

Reviewed 1 of 2 files at r2, 1 of 4 files at r6, 1 of 1 files at r10, 1 of 1 files at r11, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

[meship-starkware]

Reviewed 1 of 1 files at r10, 1 of 1 files at r11, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

[github-actions]

Artifacts upload triggered. View details here

[meship-starkware]

Reviewed 1 of 1 files at r12, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1)