-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use standard initialization for server creation #1827
Conversation
bbba509
to
1c850aa
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1827 +/- ##
===========================================
+ Coverage 40.10% 77.21% +37.11%
===========================================
Files 26 365 +339
Lines 1895 38888 +36993
Branches 1895 38888 +36993
===========================================
+ Hits 760 30028 +29268
- Misses 1100 6616 +5516
- Partials 35 2244 +2209 ☔ View full report in Codecov by Sentry. |
1c850aa
to
617c8b6
Compare
Artifacts upload triggered. View details here |
Artifacts upload triggered. View details here |
617c8b6
to
26efdc3
Compare
Artifacts upload triggered. View details here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)
26efdc3
to
fed7c0e
Compare
Artifacts upload triggered. View details here |
fed7c0e
to
7ae4d93
Compare
Artifacts upload triggered. View details here |
commit-id:c439ca8b
7ae4d93
to
ce95e82
Compare
Artifacts upload triggered. View details here |
✓ Commit merged in pull request #1834 |
Stack: