chore(node): add workspace lints #1830
Conversation
|
This change is |
giladchase
force-pushed
the
gilad/node-lints
branch
from
edf9ecd to
4d4c998
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @eitanm-starkware and @elintul)
crates/papyrus_node/examples/get_transaction_hash.rs line 82 at r1 (raw file):
.get_one::<String>("concurrent_requests") .expect("Failed parsing concurrent_requests") .parse::<usize>()
Turbofish not needed here, but kept it to be consistent with the surrounding code, and changing all surrounding code is OOS
Code quote:
.parse::<usize>()
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @eitanm-starkware)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1830 +/- ##
==========================================
- Coverage 40.10% 7.17% -32.94%
==========================================
Files 26 213 +187
Lines 1895 30066 +28171
Branches 1895 30066 +28171
==========================================
+ Hits 760 2156 +1396
- Misses 1100 27709 +26609
- Partials 35 201 +166 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Reviewable status:
giladchase
force-pushed
the
gilad/network-lints
branch
from
7802162 to
92e7432
Compare
giladchase
force-pushed
the
gilad/node-lints
branch
2 times, most recently
from
a9ec62e to
d48b96b
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
giladchase
force-pushed
the
gilad/network-lints
branch
from
92e7432 to
5972aa0
Compare
Lior banned `as` repo-wide, unless absolutely necessary. Nearly all as uses can be replaced with [Try]From which doesn't have implicit coercions like as (we encountered several bugs due to these coercions). Motivation: we are standardizing lints across the repo and CI, instead of each crate having separate sets of lints. Note: i left the `as f64` since `gauge!` expects f64, even though the metrics themselves are integers. This is probably fixable by using `counter!` instead of `gauge!`, but i haven't found anyone who knows how to test these metrics so i'm leaving it for now. I left them at the statement level intentionaly, instead of the module level, so that it won't be forgotten.
giladchase
force-pushed
the
gilad/network-lints
branch
from
5972aa0 to
1408416
Compare
Lior banned `as` repo-wide, unless absolutely necessary. Nearly all as uses can be replaced with [Try]From which doesn't have implicit coercions like as (we encountered several bugs due to these coercions). Motivation: we are standardizing lints across the repo and CI, instead of each crate having separate sets of lints. Note: the change in pointers.rs is due to cargo doc being triggered due to changes in the crate, and cargo doc thought it was a busted HTML tag :sweat_smile:
giladchase
force-pushed
the
gilad/node-lints
branch
from
d48b96b to
d06c9d6
Compare
Lior banned
asrepo-wide, unless absolutely necessary.Nearly all as uses can be replaced with [Try]From which doesn't have implicit coercions like as (we encountered several bugs due to these coercions).
Motivation: we are standardizing lints across the repo and CI, instead of each crate having separate sets of lints.