Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable stateful compression versioned constant #1836

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

yoavGrs
Copy link
Contributor

@yoavGrs yoavGrs commented Nov 5, 2024

No description provided.

@yoavGrs yoavGrs self-assigned this Nov 5, 2024
@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

github-actions bot commented Nov 5, 2024

Artifacts upload triggered. View details here

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.48%. Comparing base (e3165c4) to head (3863da9).
Report is 207 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1836       +/-   ##
===========================================
+ Coverage   40.10%   68.48%   +28.38%     
===========================================
  Files          26      102       +76     
  Lines        1895    13604    +11709     
  Branches     1895    13604    +11709     
===========================================
+ Hits          760     9317     +8557     
- Misses       1100     3886     +2786     
- Partials       35      401      +366     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

a discussion (no related file):
The python side
https://reviewable.io/reviews/starkware-industries/starkware/36170


Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @yoavGrs)

a discussion (no related file):
please rebase (we now have 0.13.4 VC), and set the flag to true in the 0.13.4 VC


@yoavGrs yoavGrs force-pushed the yoav/state_comp/versioned_constants branch from f087902 to 3863da9 Compare November 5, 2024 13:54
Copy link

github-actions bot commented Nov 5, 2024

Artifacts upload triggered. View details here

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @yoavGrs)

Copy link
Contributor Author

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware)

a discussion (no related file):

Previously, dorimedini-starkware wrote…

please rebase (we now have 0.13.4 VC), and set the flag to true in the 0.13.4 VC

Done.


Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yoavGrs)

Copy link
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 7 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yoavGrs)

@yoavGrs yoavGrs merged commit 6fc1f26 into main Nov 5, 2024
12 checks passed
@yoavGrs yoavGrs deleted the yoav/state_comp/versioned_constants branch November 5, 2024 14:15
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants