chore: starknet API add lints #1853
Conversation
|
This change is |
giladchase
force-pushed
the
gilad/rpc-lints
branch
from
1e7d462 to
62c4ff8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1853 +/- ##
==========================================
+ Coverage 40.10% 49.98% +9.87%
==========================================
Files 26 25 -1
Lines 1895 2573 +678
Branches 1895 2573 +678
==========================================
+ Hits 760 1286 +526
- Misses 1100 1222 +122
- Partials 35 65 +30 ☔ View full report in Codecov by Sentry. |
giladchase
force-pushed
the
gilad/snapi-lint
branch
from
58c6382 to
7648096
Compare
giladchase
force-pushed
the
gilad/snapi-lint
branch
from
7648096 to
57d1c0c
Compare
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on @giladchase and @noaov1)
a discussion (no related file):
why are there changes to papyrus rpc here?
giladchase
force-pushed
the
gilad/rpc-lints
branch
from
62c4ff8 to
c9abdaa
Compare
giladchase
force-pushed
the
gilad/snapi-lint
branch
from
57d1c0c to
2d946fe
Compare
There was a problem hiding this comment.
Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @noaov1)
a discussion (no related file):
Previously, dorimedini-starkware wrote…
why are there changes to papyrus rpc here?
Needed rebase, Done.
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @noaov1)
giladchase
force-pushed
the
gilad/rpc-lints
branch
from
c9abdaa to
d575cbe
Compare
giladchase
force-pushed
the
gilad/snapi-lint
branch
from
2d946fe to
32faf44
Compare
|
Benchmark movements: |
There was a problem hiding this comment.
Reviewable status:
Lior banned `as` repo-wide, unless absolutely necessary. Nearly all as uses can be replaced with [Try]From which doesn't have implicit coercions like as (we encountered several bugs due to these coercions). Motivation: we are standardizing lints across the repo and CI, instead of each crate having separate sets of lints. Notes: changes to docs are due to cargo doc now running on changed files
giladchase
force-pushed
the
gilad/snapi-lint
branch
from
32faf44 to
f33ef83
Compare
There was a problem hiding this comment.
Reviewed 4 of 4 files at r4, all commit messages.
Reviewable status:
Lior banned `as` repo-wide, unless absolutely necessary. Nearly all as uses can be replaced with [Try]From which doesn't have implicit coercions like as (we encountered several bugs due to these coercions). Motivation: we are standardizing lints across the repo and CI, instead of each crate having separate sets of lints. Notes: changes to docs are due to cargo doc now running on changed files Co-Authored-By: Gilad Chase <gilad@starkware.com>
Lior banned
asrepo-wide, unless absolutely necessary.Nearly all as uses can be replaced with [Try]From which doesn't have implicit coercions like as (we encountered several bugs due to these coercions).
Motivation: we are standardizing lints across the repo and CI, instead of each crate having separate sets of lints.