-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idan/main/add sequencer deployment tools #1856
Conversation
…an/main/add-sequencer-deployment-tools
…:starkware-libs/sequencer into idan/main/add-sequencer-deployment-tools
…:starkware-libs/sequencer into idan/main/add-sequencer-deployment-tools
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1856 +/- ##
===========================================
+ Coverage 40.10% 77.16% +37.05%
===========================================
Files 26 378 +352
Lines 1895 40027 +38132
Branches 1895 40027 +38132
===========================================
+ Hits 760 30886 +30126
- Misses 1100 6858 +5758
- Partials 35 2283 +2248 ☔ View full report in Codecov by Sentry. |
f316fa1
to
d0a0608
Compare
d0a0608
to
698cddd
Compare
mount_path=pvc.mount_path, | ||
read_only=True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The read_only
flag in the volume mount should match the corresponding PVC's read_only
setting rather than being hardcoded to true
. Consider updating to read_only=pvc.read_only
to maintain consistency between the mount and PVC configurations.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
7a6e141
to
cfbc596
Compare
deployments/sequencer/main.py
Outdated
scope=app, | ||
name="sequencer-node", | ||
namespace="sequencer-node-test", | ||
config=None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The config
parameter is marked as required in SequencerNode
's implementation but is being passed as None
here. This will cause runtime errors since SequencerNode
uses the config object without null checks. Either make the parameter optional in SequencerNode
and add appropriate null handling, or pass a valid config object at instantiation.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
6f0c4a4
to
ccae39a
Compare
No description provided.