test: add p2p class sync fail cases tests

[noamsp-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[noamsp-starkware]

• test: add p2p class sync fail cases tests #1943 👈 (View in Graphite)
• test: add p2p class sync happy flow test #1942
• refactor: add wait_for_marker to p2p_sync:client test_utils #2147 : 1 other dependent PR (#2154 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.56%. Comparing base (e3165c4) to head (9439cf3).
Report is 606 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1943       +/-   ##
===========================================
- Coverage   40.10%   26.56%   -13.55%     
===========================================
  Files          26      105       +79     
  Lines        1895    12634    +10739     
  Branches     1895    12634    +10739     
===========================================
+ Hits          760     3356     +2596     
- Misses       1100     8690     +7590     
- Partials       35      588      +553     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eitanm-starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @noamsp-starkware and @ShahakShama)

---

-- commits line 2 at r2:

Suggestion:

 negative flow
 fail cases 

---

crates/papyrus_p2p_sync/src/client/class_test.rs line 316 at r2 (raw file):

            panic!("P2P sync aborted with no failure.");
        }
        _ = parse_queries_future => {}

i recommend having a timeout clause to make sure this test ends

Code quote:

        sync_result = p2p_sync.run() => {
            sync_result.unwrap();
            panic!("P2P sync aborted with no failure.");
        }
        _ = parse_queries_future => {}

[ShahakShama]

Reviewed all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @noamsp-starkware)

---

crates/papyrus_p2p_sync/src/client/class_test.rs line 199 at r2 (raw file):

        vec![2],
        vec![
            Some(StateDiffChunk::DeclaredClass(DeclaredClass::default())),

These two will have the same hash and should also result in a conflict error. Please change one of them to a non default value

---

crates/papyrus_p2p_sync/src/client/class_test.rs line 218 at r2 (raw file):

// was returned from parse_data_for_block. We currently dont have a way to check this.
#[tokio::test]
async fn class_not_in_state_diff() {

The class_hash and class_hash_in_state_diff in the test are the same. The name of this test should be "class_is_cairo0_and_cairo1_in_state_diff" or something like that. Plus, add a new test that does what the name of this test suggests

---

crates/papyrus_p2p_sync/src/client/class_test.rs line 239 at r2 (raw file):

        vec![2],
        vec![
            Some(StateDiffChunk::DeclaredClass(DeclaredClass::default())),

This is an invalid state diff (see comment above). Change it to contain different hashes

---

crates/papyrus_p2p_sync/src/client/class_test.rs line 239 at r2 (raw file):

        vec![2],
        vec![
            Some(StateDiffChunk::DeclaredClass(DeclaredClass::default())),

This test contains two errors (conflicting hashes and missing hashes).
I think what we can do is change it to have 3 hashes in the state diff and 2 classes sent, then we can test that it fails and doesn't wait for the 3rd class to be sent