Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blockifier): update cairo submodule to tagged commit #1947

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

PearsonWhite
Copy link
Contributor

#1854 updated cairo native submodule to 26e1c67966b93acd8b183823aae6f3e4fdc5c78c instead of 564f7e2136e53a1e43033aefa3836b4dc591ffc1 (v0.2.1-alpha.0). This change points the native submodule to the tagged commit in main.

@PearsonWhite PearsonWhite added the native integration Related with the integration of Cairo Native into the Blockifier label Nov 11, 2024
@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

Artifacts upload triggered. View details here

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.58%. Comparing base (e3165c4) to head (26d3115).
Report is 404 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1947       +/-   ##
===========================================
+ Coverage   40.10%   67.58%   +27.48%     
===========================================
  Files          26      103       +77     
  Lines        1895    13846    +11951     
  Branches     1895    13846    +11951     
===========================================
+ Hits          760     9358     +8598     
- Misses       1100     4088     +2988     
- Partials       35      400      +365     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meship-starkware meship-starkware self-requested a review November 12, 2024 11:53
Copy link
Contributor

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @PearsonWhite)

Copy link
Contributor

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @PearsonWhite)


a discussion (no related file):
Please resolve conflicts so we can merge

@rodrigo-pino rodrigo-pino force-pushed the pwhite/cairo_submodule_version branch from a02a114 to 26d3115 Compare November 13, 2024 11:49
Copy link

Artifacts upload triggered. View details here

Copy link
Contributor

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dismissed @graphite-app[bot] from a discussion.
Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on @PearsonWhite and @Yoni-Starkware)

Copy link
Contributor

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @PearsonWhite and @Yoni-Starkware)

Copy link
Contributor

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @PearsonWhite and @Yoni-Starkware)

Copy link
Contributor

@avi-starkware avi-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @PearsonWhite and @Yoni-Starkware)

Copy link
Contributor

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @PearsonWhite)

@meship-starkware meship-starkware merged commit 24dd490 into main Nov 14, 2024
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
native integration Related with the integration of Cairo Native into the Blockifier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants