-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(blockifier): add text file with current compiler version for CI use #195
chore(blockifier): add text file with current compiler version for CI use #195
Conversation
e3b2330
to
e62e313
Compare
2618e0f
to
e073a68
Compare
e62e313
to
4fe6734
Compare
e073a68
to
0cc6a4f
Compare
4fe6734
to
9facef4
Compare
0cc6a4f
to
f400d64
Compare
9facef4
to
0d099c5
Compare
f400d64
to
58aca6d
Compare
0d099c5
to
a12e845
Compare
58aca6d
to
7b79e6f
Compare
imo, this is not a good idea. Apart from having to maintain 2 locations now instead of only the Code quote: v2.7.0-rc.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware, @dorimedini-starkware, @meship-starkware, and @noaov1)
crates/blockifier/tests/legacy_cairo1_compiler_tag.txt
line 1 at r2 (raw file):
v2.1.0
What's the idea here?
Code quote:
v2.1.0
a12e845
to
d2dd1b8
Compare
7b79e6f
to
738d7f2
Compare
d2dd1b8
to
10d4789
Compare
8ad0c34
to
1f6f2aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @aner-starkware, @AvivYossef-starkware, @meship-starkware, and @noaov1)
crates/blockifier/tests/legacy_cairo1_compiler_tag.txt
line 1 at r2 (raw file):
Previously, aner-starkware wrote…
Why not hardcode in the CI instead of in a different file? The test can check that the hardcoded constant in the CI is equal to the expected.
actually I think it's not even needed anymore, see top of the stack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @noaov1)
031e4da
to
6e5f836
Compare
1f6f2aa
to
e11a98a
Compare
6e5f836
to
9942ae2
Compare
4b6aa3d
to
ae71e03
Compare
9942ae2
to
0895bc5
Compare
ae71e03
to
3fd07d1
Compare
0895bc5
to
388820c
Compare
3fd07d1
to
07ec736
Compare
388820c
to
7a76151
Compare
07ec736
to
f623af9
Compare
7a76151
to
83dc987
Compare
f623af9
to
1b9c871
Compare
83dc987
to
b29a56b
Compare
1b9c871
to
452fc59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 4 files at r6, 2 of 4 files at r7, 2 of 2 files at r9, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @noaov1)
b29a56b
to
9d6f7ff
Compare
452fc59
to
ce6fbbf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r10, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @noaov1)
Merge activity
|
ce6fbbf
to
688beb1
Compare
This change is