Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blockifier): remove unnecessary func #2039

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

Yoni-Starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

Artifacts upload triggered. View details here

@ArniStarkware
Copy link
Contributor

crates/papyrus_state_reader/src/papyrus_state_test.rs line 30 at r1 (raw file):

    } else {
        panic!()
    };

This also requires a change in the toml.

Suggestion:

use assert_matches::assert_matches;

use crate::papyrus_state::PapyrusReader;

#[test]
fn test_entry_point_with_papyrus_state() -> papyrus_storage::StorageResult<()> {
    let ((storage_reader, mut storage_writer), _) = papyrus_storage::test_utils::get_test_storage();

    let test_contract = FeatureContract::TestContract(CairoVersion::Cairo0);
    let test_class_hash = test_contract.get_class_hash();
    let test_class = assert_matches!(
        test_contract.get_class(), ContractClass::V0(contract_class) => contract_class
    );

@Yoni-Starkware Yoni-Starkware force-pushed the yoni/feat-contract/remove-unnecessary-func branch from 4718615 to 00bb3a3 Compare November 14, 2024 09:28
Copy link
Collaborator Author

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @dorimedini-starkware)


crates/papyrus_state_reader/src/papyrus_state_test.rs line 30 at r1 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

This also requires a change in the toml.

Done.

Copy link

Artifacts upload triggered. View details here

Copy link

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [30.308 ms 30.355 ms 30.404 ms]
change: [+1.0126% +1.2138% +1.4094%] (p = 0.00 < 0.05)
Performance has regressed.
Found 6 outliers among 100 measurements (6.00%)
1 (1.00%) low mild
4 (4.00%) high mild
1 (1.00%) high severe

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.00%. Comparing base (e3165c4) to head (73ebd35).
Report is 384 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2039       +/-   ##
===========================================
+ Coverage   40.10%   77.00%   +36.90%     
===========================================
  Files          26      373      +347     
  Lines        1895    39695    +37800     
  Branches     1895    39695    +37800     
===========================================
+ Hits          760    30569    +29809     
- Misses       1100     6852     +5752     
- Partials       35     2274     +2239     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@Yoni-Starkware Yoni-Starkware force-pushed the yoni/feat-contract/remove-unnecessary-func branch from 00bb3a3 to 73ebd35 Compare November 14, 2024 10:04
Copy link

Artifacts upload triggered. View details here

Copy link
Contributor

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@Yoni-Starkware Yoni-Starkware merged commit 6d06b67 into main Nov 14, 2024
22 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants