-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(blockifier): remove unnecessary func #2039
chore(blockifier): remove unnecessary func #2039
Conversation
Artifacts upload triggered. View details here |
This also requires a change in the toml. Suggestion: use assert_matches::assert_matches;
use crate::papyrus_state::PapyrusReader;
#[test]
fn test_entry_point_with_papyrus_state() -> papyrus_storage::StorageResult<()> {
let ((storage_reader, mut storage_writer), _) = papyrus_storage::test_utils::get_test_storage();
let test_contract = FeatureContract::TestContract(CairoVersion::Cairo0);
let test_class_hash = test_contract.get_class_hash();
let test_class = assert_matches!(
test_contract.get_class(), ContractClass::V0(contract_class) => contract_class
); |
4718615
to
00bb3a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @dorimedini-starkware)
crates/papyrus_state_reader/src/papyrus_state_test.rs
line 30 at r1 (raw file):
Previously, ArniStarkware (Arnon Hod) wrote…
This also requires a change in the toml.
Done.
Artifacts upload triggered. View details here |
Benchmark movements: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2039 +/- ##
===========================================
+ Coverage 40.10% 77.00% +36.90%
===========================================
Files 26 373 +347
Lines 1895 39695 +37800
Branches 1895 39695 +37800
===========================================
+ Hits 760 30569 +29809
- Misses 1100 6852 +5752
- Partials 35 2274 +2239 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
00bb3a3
to
73ebd35
Compare
Artifacts upload triggered. View details here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
No description provided.