chore(tests_integration): return tx sender address

[Itay-Tsabary-Starkware]

Stack:

• chore(tests_integration): add nonce verification #2071
• chore(config): add sequencer address as required param #2070
• chore(tests_integration): return tx sender address #2056 ⬅

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

[reviewable-StarkWare]

This change is 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.61%. Comparing base (e3165c4) to head (3a2382b).
Report is 481 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2056      +/-   ##
==========================================
- Coverage   40.10%   33.61%   -6.50%     
==========================================
  Files          26      269     +243     
  Lines        1895    31203   +29308     
  Branches     1895    31203   +29308     
==========================================
+ Hits          760    10488    +9728     
- Misses       1100    19743   +18643     
- Partials       35      972     +937     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[alonh5]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Itay-Tsabary-Starkware)

---

crates/starknet_integration_tests/src/utils.rs line 186 at r1 (raw file):

}

fn create_txs_for_tx_generator_test_scenario(

Consider passing the account ID as an arg, and then you can get the contract address outside of this function.
Also can you please rename this function? It's not clear what it does.

---

crates/starknet_integration_tests/src/utils.rs line 241 at r1 (raw file):

/// Creates and runs the many txs test scenario for the sequencer integration test. Returns
/// a list of transaction hashes, in the order they are expected to be in the mempool.
pub async fn run_transaction_generator_test_scenario<'a, Fut>(

Also rename to match.

Code quote:

run_transaction_generator_test_scenario

[Itay-Tsabary-Starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @alonh5)

---

crates/starknet_integration_tests/src/utils.rs line 186 at r1 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Consider passing the account ID as an arg, and then you can get the contract address outside of this function.
Also can you please rename this function? It's not clear what it does.

Added a todo to address that, this will require a few changes elsewhere.

---

crates/starknet_integration_tests/src/utils.rs line 241 at r1 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Also rename to match.

The todo above includes renaming this function as well.

[alonh5]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

---

crates/starknet_integration_tests/src/utils.rs line 186 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Added a todo to address that, this will require a few changes elsewhere.

It's a small change, I opened a PR over your stack to show you what I meant.

[Itay-Tsabary-Starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)