chore(infra): share get_absolute_path infra util with snapi test utils

[ArniStarkware]

No description provided.

[reviewable-StarkWare]

This change is 

[ArniStarkware]

• chore(infra): share get_absolute_path infra util with snapi test utils #2075 : 2 dependent PRs (#2169 , #2203 ) 👈 (View in Graphite)
• chore(infra): move get_absolute_path function to infra_utils #2074
• feat: create infra utils crate #2073
• chore: share the test util path_in_resources #2052
• chore: share the test util get_absolute_path #2026
• chore: move nonce manager struct near the impl block #2020
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.21%. Comparing base (e3165c4) to head (a985e92).
Report is 529 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2075       +/-   ##
===========================================
+ Coverage   40.10%   77.21%   +37.11%     
===========================================
  Files          26      386      +360     
  Lines        1895    40386    +38491     
  Branches     1895    40386    +38491     
===========================================
+ Hits          760    31185    +30425     
- Misses       1100     6899     +5799     
- Partials       35     2302     +2267     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 14 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)

---

crates/infra_utils/src/path.rs line 6 at r1 (raw file):

pub static PATH_TO_CARGO_MANIFEST_DIR: LazyLock<Option<PathBuf>> =
    LazyLock::new(|| env::var("CARGO_MANIFEST_DIR").ok().map(|dir| Path::new(&dir).into()));

Please make this a private function, and create a function that returns the cloned path. The benefit of that would be that

1. users wouldn't have to clone the path whenever they use it
2. we can later add code that returns this path even when running not through cargo

Code quote:

pub static PATH_TO_CARGO_MANIFEST_DIR: LazyLock<Option<PathBuf>> =
    LazyLock::new(|| env::var("CARGO_MANIFEST_DIR").ok().map(|dir| Path::new(&dir).into()));

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.698 ms 35.186 ms 35.761 ms]
change: [+1.4422% +2.9514% +4.7549%] (p = 0.00 < 0.05)
Performance has regressed.
Found 10 outliers among 100 measurements (10.00%)
2 (2.00%) high mild
8 (8.00%) high severe

[ArniStarkware]

Reviewable status: 0 of 14 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)

---

crates/infra_utils/src/path.rs line 6 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Please make this a private function, and create a function that returns the cloned path. The benefit of that would be that

1. users wouldn't have to clone the path whenever they use it
2. we can later add code that returns this path even when running not through cargo

Done.
We can move functionality from get_absolute_path into a function called: manifest_dir, in another PR.

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.959 ms 35.457 ms 36.038 ms]
change: [+1.0141% +3.2102% +5.4779%] (p = 0.00 < 0.05)
Performance has regressed.
Found 9 outliers among 100 measurements (9.00%)
9 (9.00%) high severe

full_committer_flow performance regressed!
full_committer_flow time: [29.808 ms 29.866 ms 29.948 ms]
change: [+1.0077% +1.2650% +1.5710%] (p = 0.00 < 0.05)
Performance has regressed.
Found 4 outliers among 100 measurements (4.00%)
3 (3.00%) high mild
1 (1.00%) high severe

[Itay-Tsabary-Starkware]

Reviewed 6 of 14 files at r1, 8 of 8 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

[ArniStarkware]

Merge activity

• Nov 21, 2:52 AM EST: A user started a stack merge that includes this pull request via Graphite.
• Nov 21, 2:54 AM EST: Graphite rebased this pull request as part of a merge.
• Nov 21, 3:15 AM EST: A user merged this pull request with Graphite.

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [29.991 ms 30.066 ms 30.159 ms]
change: [+1.7203% +2.0320% +2.3621%] (p = 0.00 < 0.05)
Performance has regressed.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severe