Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(blockifier): implement get_clash_at syscall for native #2077

Merged
merged 1 commit into from
Nov 17, 2024
Merged

feat(blockifier): implement get_clash_at syscall for native #2077

merged 1 commit into from
Nov 17, 2024

Conversation

rodrigo-pino
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@rodrigo-pino rodrigo-pino added the native integration Related with the integration of Cairo Native into the Blockifier label Nov 14, 2024
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@codecov Codecov
Copy link

codecov bot commented Nov 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.26%. Comparing base (55b4849) to head (9a7936d).
Report is 1 commits behind head on rdr/update-native.

Additional details and impacted files 
@@                  Coverage Diff                  @@
##           rdr/update-native    #2077      +/-   ##
=====================================================
- Coverage              77.26%   69.26%   -8.00%     
=====================================================
  Files                    376      105     -271     
  Lines                  39929    13763   -26166     
  Branches               39929    13763   -26166     
=====================================================
- Hits                   30851     9533   -21318     
+ Misses                  6796     3827    -2969     
+ Partials                2282      403    -1879

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Yoni-Starkware
Yoni-Starkware approved these changes Nov 17, 2024
View reviewed changes
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @avi-starkware and @meship-starkware)

meship-starkware
meship-starkware approved these changes Nov 17, 2024
View reviewed changes
Copy link
Contributor

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @avi-starkware)

@Yoni-Starkware Yoni-Starkware merged commit a16a620 into rdr/update-native Nov 17, 2024
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meship-starkware meship-starkware meship-starkware approved these changes

@Yoni-Starkware Yoni-Starkware Yoni-Starkware approved these changes

@avi-starkware avi-starkware Awaiting requested review from avi-starkware

Assignees
No one assigned
Labels
native integration Related with the integration of Cairo Native into the Blockifier
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rodrigo-pino @reviewable-StarkWare @Yoni-Starkware @meship-starkware