Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sequencer_infra): add component client trait for local client #2078

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware commented Nov 15, 2024

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 18.15%. Comparing base (e3165c4) to head (ee3033f).
Report is 857 commits behind head on main.

Files with missing lines Patch % Lines
crates/starknet_batcher_types/src/communication.rs 0.00% 6 Missing ⚠️
...ra/src/component_server/remote_component_server.rs 64.28% 5 Missing ⚠️
crates/starknet_mempool_types/src/communication.rs 0.00% 3 Missing ⚠️
crates/starknet_gateway_types/src/communication.rs 0.00% 2 Missing ⚠️
...es/starknet_mempool_p2p_types/src/communication.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2078       +/-   ##
===========================================
- Coverage   40.10%   18.15%   -21.96%     
===========================================
  Files          26      240      +214     
  Lines        1895    28910    +27015     
  Branches     1895    28910    +27015     
===========================================
+ Hits          760     5248     +4488     
- Misses       1100    23302    +22202     
- Partials       35      360      +325     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the title chore(sequencere_infra): add component client trait for local client chore(sequencer_infra): add component client trait for local client Nov 16, 2024
Copy link

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants