-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sequencer_infra): add component client trait for local client #2084
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2084 +/- ##
===========================================
- Coverage 40.10% 18.12% -21.99%
===========================================
Files 26 243 +217
Lines 1895 28988 +27093
Branches 1895 28988 +27093
===========================================
+ Hits 760 5254 +4494
- Misses 1100 23375 +22275
- Partials 35 359 +324 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 9 files at r1, all commit messages.
Reviewable status: 8 of 9 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)
crates/starknet_sequencer_infra/src/component_server/remote_component_server.rs
line 111 at r1 (raw file):
Request: Serialize + DeserializeOwned + Send + Sync + 'static, Response: Serialize + DeserializeOwned + Send + Sync + 'static, LocalComponentClient<Request, Response>: ComponentClient<Request, Response>,
Why is this necessary? The concrete LocalComponentClient struct already implements the ComponentClient trait.
Code quote:
LocalComponentClient<Request, Response>: ComponentClient<Request, Response>,
ffca5ca
to
9bb7bdd
Compare
Artifacts upload triggered. View details here |
commit-id:a48a5aec
9bb7bdd
to
2debf78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 8 of 10 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)
crates/starknet_sequencer_infra/src/component_server/remote_component_server.rs
line 111 at r1 (raw file):
Previously, nadin-Starkware (Nadin Jbara) wrote…
Why is this necessary? The concrete LocalComponentClient struct already implements the ComponentClient trait.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 9 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
Stack: