Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sequencer_infra): add component client trait for local client #2084

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 7.40741% with 25 lines in your changes missing coverage. Please review.

Project coverage is 18.12%. Comparing base (e3165c4) to head (2debf78).
Report is 426 commits behind head on main.

Files with missing lines Patch % Lines
crates/starknet_batcher_types/src/communication.rs 0.00% 12 Missing ⚠️
crates/starknet_mempool_types/src/communication.rs 0.00% 6 Missing ⚠️
...es/starknet_mempool_p2p_types/src/communication.rs 0.00% 4 Missing ⚠️
crates/starknet_gateway_types/src/communication.rs 0.00% 2 Missing ⚠️
...tes/starknet_state_sync_types/src/communication.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2084       +/-   ##
===========================================
- Coverage   40.10%   18.12%   -21.99%     
===========================================
  Files          26      243      +217     
  Lines        1895    28988    +27093     
  Branches     1895    28988    +27093     
===========================================
+ Hits          760     5254     +4494     
- Misses       1100    23375    +22275     
- Partials       35      359      +324     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 9 files at r1, all commit messages.
Reviewable status: 8 of 9 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)


crates/starknet_sequencer_infra/src/component_server/remote_component_server.rs line 111 at r1 (raw file):

    Request: Serialize + DeserializeOwned + Send + Sync + 'static,
    Response: Serialize + DeserializeOwned + Send + Sync + 'static,
    LocalComponentClient<Request, Response>: ComponentClient<Request, Response>,

Why is this necessary? The concrete LocalComponentClient struct already implements the ComponentClient trait.

Code quote:

LocalComponentClient<Request, Response>: ComponentClient<Request, Response>,

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from spr/main/90fa2e32 to main November 17, 2024 12:45
Copy link

Artifacts upload triggered. View details here

Copy link
Contributor Author

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 8 of 10 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)


crates/starknet_sequencer_infra/src/component_server/remote_component_server.rs line 111 at r1 (raw file):

Previously, nadin-Starkware (Nadin Jbara) wrote…

Why is this necessary? The concrete LocalComponentClient struct already implements the ComponentClient trait.

Done.

Copy link
Collaborator

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

Copy link
Contributor Author

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 9 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@ShahakShama ShahakShama merged commit 24b237b into main Nov 17, 2024
17 checks passed
@ShahakShama ShahakShama deleted the spr/main/a48a5aec branch November 17, 2024 13:21
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants