Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(blockifier): share the utility next_storage_key to starknet api #2091

Merged
merged 1 commit into from
Nov 17, 2024
Merged

chore(blockifier): share the utility next_storage_key to starknet api #2091

merged 1 commit into from
Nov 17, 2024

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Nov 17, 2024 •
edited
Loading

The TODO was added on this PR from the blockifier repo.

@reviewable-StarkWare
Copy link

This change is Reviewable

@ArniStarkware Graphite App
Copy link
Contributor Author

ArniStarkware commented Nov 17, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@ArniStarkware ArniStarkware marked this pull request as ready for review November 17, 2024 07:18
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@ArniStarkware ArniStarkware force-pushed the arni/chore/next_storage_key/move_to_snapi branch from 16a4f88 to 846a828 Compare November 17, 2024 07:21
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@ArniStarkware ArniStarkware changed the title chore(blockfier): share the utility next_storage_key to starknet api chore(blockifier): share the utility next_storage_key to starknet api Nov 17, 2024
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@codecov Codecov
Copy link

codecov bot commented Nov 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.16%. Comparing base (e3165c4) to head (846a828).
Report is 413 commits behind head on main.

Files with missing lines Patch % Lines
crates/blockifier/src/abi/sierra_types.rs 0.00% 1 Missing ⚠️
crates/blockifier/src/fee/fee_utils.rs 0.00% 0 Missing and 1 partial ⚠️
crates/blockifier/src/state/state_api.rs 0.00% 0 Missing and 1 partial ⚠️
crates/starknet_api/src/state.rs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2091       +/-   ##
===========================================
+ Coverage   40.10%   77.16%   +37.05%     
===========================================
  Files          26      377      +351     
  Lines        1895    39941    +38046     
  Branches     1895    39941    +38046     
===========================================
+ Hits          760    30820    +30060     
- Misses       1100     6838     +5738     
- Partials       35     2283     +2248

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware ArniStarkware mentioned this pull request Nov 17, 2024
Merged
dorimedini-starkware
dorimedini-starkware approved these changes Nov 17, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @barak-b-starkware and @noaov1)

@ArniStarkware ArniStarkware removed the request for review from noaov1 November 17, 2024 08:24
@ArniStarkware ArniStarkware merged commit d0a84e0 into main Nov 17, 2024
16 of 26 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2024
@ArniStarkware ArniStarkware deleted the arni/chore/next_storage_key/move_to_snapi branch November 28, 2024 13:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dorimedini-starkware dorimedini-starkware dorimedini-starkware approved these changes

@barak-b-starkware barak-b-starkware Awaiting requested review from barak-b-starkware

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArniStarkware @reviewable-StarkWare @dorimedini-starkware