chore(blockifier): add ContractClassManagerConfig

[avivg-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[avivg-starkware]

• chore(blockifier): add ContractClassManagerConfig #2092 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload triggered. View details here

[codecov]

Codecov Report

Attention: Patch coverage is 47.76119% with 35 lines in your changes missing coverage. Please review.

Project coverage is 59.45%. Comparing base (e3165c4) to head (ea70b8f).
Report is 611 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/blockifier/src/blockifier/config.rs	0.00%	30 Missing ⚠️
crates/native_blockifier/src/py_block_executor.rs	78.26%	5 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2092       +/-   ##
===========================================
+ Coverage   40.10%   59.45%   +19.35%     
===========================================
  Files          26      151      +125     
  Lines        1895    18359    +16464     
  Branches     1895    18359    +16464     
===========================================
+ Hits          760    10916    +10156     
- Misses       1100     6742     +5642     
- Partials       35      701      +666     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[avi-starkware]

Reviewed 1 of 5 files at r1, all commit messages.
Reviewable status: 1 of 5 files reviewed, 6 unresolved discussions (waiting on @avivg-starkware, @meship-starkware, and @Yoni-Starkware)

---

crates/blockifier/src/test_utils/transfers_generator.rs line 55 at r2 (raw file):

            recipient_generator_type: RECIPIENT_GENERATOR_TYPE,
            concurrency_config: ConcurrencyConfig::create_for_testing(false),
            run_native: true,

Suggestion:

false

---

crates/blockifier/src/test_utils/transfers_generator.rs line 86 at r2 (raw file):

        let executor_config = TransactionExecutorConfig {
            concurrency_config: config.concurrency_config.clone(),
            run_native: true,

Suggestion:

            run_native: config.run_native,

---

crates/native_blockifier/src/py_block_executor_test.rs line 42 at r2 (raw file):

    let mut block_executor = PyBlockExecutor::create_for_testing(
        PyConcurrencyConfig::default(),
        true, // TODO(AvivG): Default value should be different?

Suggestion:

        false, // TODO(AvivG): Default value should be different?

---

crates/native_blockifier/src/py_block_executor_test.rs line 123 at r2 (raw file):

    let mut block_executor = PyBlockExecutor::native_create_for_testing(
        Default::default(),
        true, // TODO(Aviv): Default value should be different?

Suggestion:

        false, // TODO(Aviv): Default value should be different?

---

crates/blockifier/src/blockifier/config.rs line 26 at r2 (raw file):

        TransactionExecutorConfig {
            concurrency_config: ConcurrencyConfig::default(),
            run_native: true,

We do not want it to run by default until the feature is ready.

Suggestion:

            run_native: false,

---

crates/blockifier/src/blockifier/config.rs line 37 at r2 (raw file):

            "run_native",
            &self.run_native,
            "Flag to enable or disable the use of native execution.",

Suggestion:

            "Enables Cairo native execution.",

[avi-starkware]

Reviewed 3 of 5 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @avivg-starkware, @meship-starkware, and @Yoni-Starkware)

[meship-starkware]

Reviewed 4 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @avivg-starkware and @Yoni-Starkware)

[github-actions]

Artifacts upload triggered. View details here

[avivg-starkware]

Reviewable status: 1 of 5 files reviewed, 6 unresolved discussions (waiting on @avi-starkware, @meship-starkware, and @Yoni-Starkware)

---

crates/blockifier/src/blockifier/config.rs line 26 at r2 (raw file):

Previously, avi-starkware wrote…

We do not want it to run by default until the feature is ready.

Done.

---

crates/blockifier/src/test_utils/transfers_generator.rs line 55 at r2 (raw file):

            recipient_generator_type: RECIPIENT_GENERATOR_TYPE,
            concurrency_config: ConcurrencyConfig::create_for_testing(false),
            run_native: true,

Done.

---

crates/blockifier/src/test_utils/transfers_generator.rs line 86 at r2 (raw file):

        let executor_config = TransactionExecutorConfig {
            concurrency_config: config.concurrency_config.clone(),
            run_native: true,

Done.

---

crates/native_blockifier/src/py_block_executor_test.rs line 42 at r2 (raw file):

    let mut block_executor = PyBlockExecutor::create_for_testing(
        PyConcurrencyConfig::default(),
        true, // TODO(AvivG): Default value should be different?

Done.

---

crates/native_blockifier/src/py_block_executor_test.rs line 123 at r2 (raw file):

    let mut block_executor = PyBlockExecutor::native_create_for_testing(
        Default::default(),
        true, // TODO(Aviv): Default value should be different?

Done.

---

crates/blockifier/src/blockifier/config.rs line 37 at r2 (raw file):

            "run_native",
            &self.run_native,
            "Flag to enable or disable the use of native execution.",

Done.

[github-actions]

Artifacts upload triggered. View details here

[avi-starkware]

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @avivg-starkware and @Yoni-Starkware)

---

crates/native_blockifier/src/py_block_executor_test.rs line 42 at r2 (raw file):

Previously, avivg-starkware wrote…

Done.

Remove the TODO as well.

---

crates/native_blockifier/src/py_block_executor_test.rs line 123 at r2 (raw file):

Previously, avivg-starkware wrote…

Done.

Remove the TODO as well.

[meship-starkware]

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @avivg-starkware and @Yoni-Starkware)

[avi-starkware]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @avivg-starkware and @Yoni-Starkware)

---

crates/blockifier/src/blockifier/config.rs line 10 at r3 (raw file):

pub struct TransactionExecutorConfig {
    pub concurrency_config: ConcurrencyConfig,
    pub run_native: bool,

Let's change the name of the flag everywhere.
The word native by itself is confusing because it is sometimes used to refer to the native_blockifier crate.

Suggestion:

    pub run_cairo_native: bool,

---

config/sequencer/default_config.json line 110 at r3 (raw file):

    "description": "Flag to enable or disable the use of native execution.",
    "privacy": "Public",
    "value": true

Notice that the json was not affected by your changes of config.rs

Code quote:

    "description": "Flag to enable or disable the use of native execution.",
    "privacy": "Public",
    "value": true

[github-actions]

Artifacts upload triggered. View details here

[avi-starkware]

crates/native_blockifier/src/py_block_executor.rs line 127 at r4 (raw file):

    pub block_compilation: bool,
    pub global_contract_cache_size: usize,
}

What does block_compilation mean?
Why add the global_contract_cache_size here?
We are going to have 4 caches and a queue. All with size limits. Shouldn't we wait for the struct to be finalized before deciding on the config for it?

Code quote:

pub struct MeshiAviConfig {
    pub run_cairo_native: bool,
    pub block_compilation: bool,
    pub global_contract_cache_size: usize,
}

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[avivg-starkware]

Reviewable status: 0 of 7 files reviewed, 9 unresolved discussions (waiting on @avi-starkware, @meship-starkware, and @Yoni-Starkware)

---

crates/blockifier/src/blockifier/config.rs line 10 at r3 (raw file):

Previously, avi-starkware wrote…

Let's change the name of the flag everywhere.
The word native by itself is confusing because it is sometimes used to refer to the native_blockifier crate.

Done.

---

crates/blockifier/src/state/global_cache.rs line 17 at r5 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Yes

Done.

---

crates/native_blockifier/src/py_block_executor_test.rs line 42 at r2 (raw file):

Previously, avi-starkware wrote…

Remove the TODO as well.

Done.

---

crates/native_blockifier/src/py_block_executor_test.rs line 123 at r2 (raw file):

Previously, avi-starkware wrote…

Remove the TODO as well.

Done.

---

config/sequencer/default_config.json line 110 at r3 (raw file):

Previously, avi-starkware wrote…

Notice that the json was not affected by your changes of config.rs

I see thanks

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[avivg-starkware]

Reviewable status: 0 of 7 files reviewed, 8 unresolved discussions (waiting on @avi-starkware, @meship-starkware, and @Yoni-Starkware)

---

crates/blockifier/src/blockifier/config.rs line 70 at r5 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

block_on_native_compilation/wait_on_native_compilation

Done.

---

crates/blockifier/src/blockifier/config.rs line 68 at r5 (raw file):

#[derive(Clone, Debug, Deserialize, PartialEq, Serialize)]
pub struct CairoNativeConfig {

Done.

---

crates/blockifier/src/blockifier/config.rs line 71 at r5 (raw file):

    pub run_cairo_native: bool,
    pub block_compilation: bool,
    pub global_contract_cache_size: usize,

Done.

[meship-starkware]

Reviewed 1 of 5 files at r4, 1 of 6 files at r5, 1 of 2 files at r6, 4 of 4 files at r7, all commit messages.
Reviewable status: all files reviewed, 8 unresolved discussions (waiting on @avi-starkware and @Yoni-Starkware)

[github-actions]

Artifacts upload triggered. View details here

[avi-starkware]

Reviewed 1 of 4 files at r7, 1 of 1 files at r8, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @Yoni-Starkware)

[Yoni-Starkware]

Reviewed 1 of 2 files at r6, 3 of 4 files at r7, 1 of 1 files at r8, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)

[meship-starkware]

Reviewed 1 of 1 files at r8.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)

[github-actions]

Artifacts upload workflows:

• Started at 2024-11-27T10:58:17Z
• Started at 2024-11-27T12:51:03Z
• Started at 2024-11-27T12:51:21Z
• Started at 2024-11-27T16:31:07Z
• Started at 2024-11-27T16:55:23Z

[Yoni-Starkware]

Reviewed 2 of 2 files at r9, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)

[Yoni-Starkware]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)

[avivg-starkware]

Reviewed 2 of 4 files at r7, 1 of 1 files at r8, 2 of 2 files at r9.
Reviewable status: 4 of 7 files reviewed, all discussions resolved (waiting on @meship-starkware and @Yoni-Starkware)

[avivg-starkware]

Reviewed 3 of 3 files at r11, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)