Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blockifier): simplify the creation of 'validate_calldata' #2094

Merged

Conversation

avivg-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@avivg-starkware avivg-starkware marked this pull request as ready for review November 17, 2024 08:21
Copy link

Artifacts upload triggered. View details here

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.37%. Comparing base (e3165c4) to head (c7137aa).
Report is 447 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2094       +/-   ##
===========================================
+ Coverage   40.10%   69.37%   +29.26%     
===========================================
  Files          26      105       +79     
  Lines        1895    13832    +11937     
  Branches     1895    13832    +11937     
===========================================
+ Hits          760     9596     +8836     
- Misses       1100     3833     +2733     
- Partials       35      403      +368     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/simplify_creation_of_validate_calldata branch from 6616615 to f0b2a8e Compare November 17, 2024 09:54
Copy link

Artifacts upload triggered. View details here

@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/simplify_creation_of_validate_calldata branch from f0b2a8e to c7137aa Compare November 17, 2024 10:59
Copy link

Artifacts upload triggered. View details here

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)

@avivg-starkware avivg-starkware merged commit a6f4987 into main Nov 17, 2024
12 checks passed
@avivg-starkware avivg-starkware deleted the avivg/blockifier/simplify_creation_of_validate_calldata branch November 17, 2024 18:35
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants