-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(blockifier): make the utility felt_to_u128 private #2095
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Artifacts upload triggered. View details here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is a simplified version of #2093. It solves a few issues I had, hopefully in the path of least resistance.
Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @barak-b-starkware, @dorimedini-starkware, and @noaov1)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2095 +/- ##
===========================================
+ Coverage 40.10% 77.27% +37.17%
===========================================
Files 26 105 +79
Lines 1895 13766 +11871
Branches 1895 13766 +11871
===========================================
+ Hits 760 10638 +9878
- Misses 1100 2669 +1569
- Partials 35 459 +424 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @barak-b-starkware and @noaov1)
0708895
to
f6891af
Compare
Artifacts upload triggered. View details here |
No description provided.