Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blockifier): make the utility felt_to_u128 private #2095

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

@ArniStarkware ArniStarkware marked this pull request as ready for review November 17, 2024 08:47
Copy link

Artifacts upload triggered. View details here

Copy link
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a simplified version of #2093. It solves a few issues I had, hopefully in the path of least resistance.

Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @barak-b-starkware, @dorimedini-starkware, and @noaov1)

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.27%. Comparing base (e3165c4) to head (f6891af).
Report is 416 commits behind head on main.

Files with missing lines Patch % Lines
crates/starknet_api/src/core.rs 0.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2095       +/-   ##
===========================================
+ Coverage   40.10%   77.27%   +37.17%     
===========================================
  Files          26      105       +79     
  Lines        1895    13766    +11871     
  Branches     1895    13766    +11871     
===========================================
+ Hits          760    10638     +9878     
- Misses       1100     2669     +1569     
- Partials       35      459      +424     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @barak-b-starkware and @noaov1)

@ArniStarkware ArniStarkware force-pushed the arni/blockifier/abi/private_felt_to_u128 branch from 0708895 to f6891af Compare November 17, 2024 09:21
Copy link

Artifacts upload triggered. View details here

@ArniStarkware ArniStarkware merged commit f0436f8 into main Nov 17, 2024
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2024
@ArniStarkware ArniStarkware deleted the arni/blockifier/abi/private_felt_to_u128 branch November 28, 2024 13:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants