Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blockifier): remove unnecessary code from test #2098

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

Yoni-Starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

Artifacts upload triggered. View details here

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.24%. Comparing base (e3165c4) to head (f04f152).
Report is 421 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2098       +/-   ##
===========================================
+ Coverage   40.10%   69.24%   +29.14%     
===========================================
  Files          26      105       +79     
  Lines        1895    13755    +11860     
  Branches     1895    13755    +11860     
===========================================
+ Hits          760     9525     +8765     
- Misses       1100     3827     +2727     
- Partials       35      403      +368     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @avi-starkware)

@Yoni-Starkware Yoni-Starkware merged commit 86461e3 into main Nov 17, 2024
12 checks passed
@Yoni-Starkware Yoni-Starkware deleted the yoni/deploy-sys/fix-test branch November 17, 2024 11:43
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants