chore(blockifier): cleanup use of enforce_fee() by AccountTransaction #2100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2100 +/- ##
===========================================
+ Coverage 40.10% 69.37% +29.26%
===========================================
Files 26 105 +79
Lines 1895 13832 +11937
Branches 1895 13832 +11937
===========================================
+ Hits 760 9596 +8836
- Misses 1100 3833 +2733
- Partials 35 403 +368 ☔ View full report in Codecov by Sentry. |
avivg-starkware
force-pushed
the
avivg/blockifier/enforce_fee_simple_code_cleanup
branch
from
e9a33fe to
32d4bbf
Compare
|
Artifacts upload triggered. View details here |
|
Artifacts upload triggered. View details here |
avivg-starkware
force-pushed
the
avivg/blockifier/enforce_fee_simple_code_cleanup
branch
from
32d4bbf to
2c85173
Compare
|
Artifacts upload triggered. View details here |
avivg-starkware
force-pushed
the
avivg/blockifier/enforce_fee_simple_code_cleanup
branch
from
2c85173 to
432d24f
Compare
|
Artifacts upload triggered. View details here |
Yoni-Starkware
approved these changes
Nov 17, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)
avivg-starkware
deleted the
avivg/blockifier/enforce_fee_simple_code_cleanup
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.