Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sync): sync's run takes ownership of self #2110

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

ShahakShama
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor

@DvirYo-starkware DvirYo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 13.42%. Comparing base (e3165c4) to head (cdbe4a2).
Report is 425 commits behind head on main.

Files with missing lines Patch % Lines
crates/papyrus_node/src/run.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2110       +/-   ##
===========================================
- Coverage   40.10%   13.42%   -26.69%     
===========================================
  Files          26      216      +190     
  Lines        1895    29683    +27788     
  Branches     1895    29683    +27788     
===========================================
+ Hits          760     3984     +3224     
- Misses       1100    25284    +24184     
- Partials       35      415      +380     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShahakShama ShahakShama merged commit e44c003 into main Nov 17, 2024
17 checks passed
@ShahakShama ShahakShama deleted the shahak/sync_run_takes_ownership branch November 17, 2024 13:11
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants