refactor(config): remove separation of required and non required config pointers

[yair-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[yair-starkware]

• chore(gateway,batcher): make gw and batcher use same values for execution #1954
• feat(config): struct pointers #1953
• refactor(config): remove separation of required and non required config pointers #2111 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.24%. Comparing base (e3165c4) to head (1b8edd9).
Report is 452 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #2111       +/-   ##
==========================================
- Coverage   40.10%   6.24%   -33.86%     
==========================================
  Files          26     262      +236     
  Lines        1895   30559    +28664     
  Branches     1895   30559    +28664     
==========================================
+ Hits          760    1909     +1149     
- Misses       1100   28567    +27467     
- Partials       35      83       +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @yair-starkware)

---

crates/starknet_sequencer_node/src/config/config_test.rs line 122 at r1 (raw file):

    let expected_required_params = deserialized.as_object_mut().unwrap();
    expected_required_params.retain(|_, value| {
        let param = serde_json::from_value::<SerializedParam>(value.clone()).unwrap();

Is the clone needed?

Code quote:

.clone()

---

crates/starknet_sequencer_node/src/config/config_test.rs line 126 at r1 (raw file):

    });
    let expected_required_keys =
        expected_required_params.keys().cloned().collect::<HashSet<String>>();

IIUC this can be achieved more elegantly using https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.filter_map.
WDYT?

Code quote:

    expected_required_params.retain(|_, value| {
        let param = serde_json::from_value::<SerializedParam>(value.clone()).unwrap();
        param.is_required()
    });
    let expected_required_keys =
        expected_required_params.keys().cloned().collect::<HashSet<String>>();

[yair-starkware]

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @Itay-Tsabary-Starkware)

---

crates/starknet_sequencer_node/src/config/config_test.rs line 122 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Is the clone needed?

Yes, value is borrowed and deserialization is consuming

---

crates/starknet_sequencer_node/src/config/config_test.rs line 126 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

IIUC this can be achieved more elegantly using https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.filter_map.
WDYT?

Tried, didn't go well.

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @yair-starkware)

[Itay-Tsabary-Starkware]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)

[yair-starkware]

Merge activity

• Nov 18, 4:13 AM EST: A user started a stack merge that includes this pull request via Graphite.
• Nov 18, 4:13 AM EST: A user merged this pull request with Graphite.