chore(blockifier): compute valid retdata directly

[ArniStarkware]

Created to address a thought on: #2104.

[reviewable-StarkWare]

This change is 

[ArniStarkware]

• chore(blockifier): compute valid retdata directly #2113 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.28%. Comparing base (e3165c4) to head (4d59141).
Report is 479 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2113       +/-   ##
===========================================
+ Coverage   40.10%   77.28%   +37.18%     
===========================================
  Files          26      108       +82     
  Lines        1895    13948    +12053     
  Branches     1895    13948    +12053     
===========================================
+ Hits          760    10780    +10020     
- Misses       1100     2707     +1607     
- Partials       35      461      +426     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[ayeletstarkware]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware, @dorimedini-starkware, and @MohammadNassar1)

---

crates/blockifier/src/transaction/constants.rs line 21 at r1 (raw file):

// Expected return value of a `validate` entry point: `VALID`.
pub static VALIDATE_RETDATA: LazyLock<Felt> =
    LazyLock::new(|| ascii_as_felt("VALID").expect("Failed to parse ASCII"));

why is the lock needed?

[ArniStarkware]

crates/blockifier/src/transaction/constants.rs line 21 at r1 (raw file):

Previously, ayeletstarkware (Ayelet Zilber) wrote…

why is the lock needed?

Here is what I modeled after.

[ayeletstarkware]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware and @MohammadNassar1)

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [35.511 ms 35.966 ms 36.505 ms]
change: [+1.4804% +3.6853% +5.8113%] (p = 0.00 < 0.05)
Performance has regressed.
Found 9 outliers among 100 measurements (9.00%)
1 (1.00%) high mild
8 (8.00%) high severe

full_committer_flow performance regressed!
full_committer_flow time: [30.470 ms 30.511 ms 30.555 ms]
change: [+1.2194% +1.4905% +1.7526%] (p = 0.00 < 0.05)
Performance has regressed.
Found 5 outliers among 100 measurements (5.00%)
2 (2.00%) low mild
2 (2.00%) high mild
1 (1.00%) high severe

[ayeletstarkware]

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware and @MohammadNassar1)

---

crates/blockifier/src/transaction/constants.rs line 21 at r1 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

Here is what I modeled after.

Don't you want to remove it and use starknet_api's VALIDATE_RETDATA?

[ArniStarkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware and @MohammadNassar1)

---

crates/blockifier/src/transaction/constants.rs line 21 at r1 (raw file):

Previously, ayeletstarkware (Ayelet Zilber) wrote…

Don't you want to remove it and use starknet_api's VALIDATE_RETDATA?

Yes. The comment thread is now on a deleted file. The change appears in crates/starknet_api/src/transaction/constants.rs on this commit.

[ayeletstarkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware and @MohammadNassar1)