Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sequencer_infra): remove redundant clones #2119

Merged
merged 8 commits into from
Nov 17, 2024

Conversation

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 18.18%. Comparing base (e3165c4) to head (d06d399).
Report is 445 commits behind head on main.

Files with missing lines Patch % Lines
...ra/src/component_client/remote_component_client.rs 95.23% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2119       +/-   ##
===========================================
- Coverage   40.10%   18.18%   -21.92%     
===========================================
  Files          26      241      +215     
  Lines        1895    28907    +27012     
  Branches     1895    28907    +27012     
===========================================
+ Hits          760     5258     +4498     
- Misses       1100    23288    +22188     
- Partials       35      361      +326     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

Copy link
Contributor Author

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from spr/main/764ee8d0 to main November 17, 2024 17:40
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware merged commit a5e2fce into main Nov 17, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants