Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sync): add test that checks StateSyncRunner runs sync future #2120

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

ShahakShama
Copy link
Contributor

  • feat(sync): state sync runner runs central sync in background
  • test(sync): add test that checks StateSyncRunner runs sync future

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

Artifacts upload triggered. View details here

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.49%. Comparing base (e3165c4) to head (0c65339).
Report is 541 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2120       +/-   ##
==========================================
- Coverage   40.10%   4.49%   -35.61%     
==========================================
  Files          26      91       +65     
  Lines        1895    8095     +6200     
  Branches     1895    8095     +6200     
==========================================
- Hits          760     364      -396     
- Misses       1100    7629     +6529     
- Partials       35     102       +67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ShahakShama ShahakShama force-pushed the shahak/sync_runner_runs_sync_test branch from c5e3e96 to 0c65339 Compare November 21, 2024 08:35
Copy link
Contributor

@AlonLStarkWare AlonLStarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 3 files at r2, 5 of 5 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)

@ShahakShama ShahakShama merged commit 0957e41 into main Nov 21, 2024
10 checks passed
@ShahakShama ShahakShama deleted the shahak/sync_runner_runs_sync_test branch November 21, 2024 11:48
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants